[WebsiteSettings] Update permission bubble manager policy

[WebsiteSettings] Update permission bubble manager policy

This policy is more in accord with the design doc changes. Moves to
showing the dialog upon DOMContentLoaded in source pages, and then
subsequently for user gestures.

R=leng@chromium.org
BUG=332115, 364159
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266855

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267099

[leng, 2014-04-18 22:50:20]

lgtm

[Greg Billock, 2014-04-21 16:29:10]

+markusheintz. Please take a look.

[Greg Billock, 2014-04-21 21:31:44]

On 2014/04/21 16:29:10, Greg Billock wrote:
> +markusheintz. Please take a look.

+rdsmith for download owners

[Randy Smith (Not in Mondays), 2014-04-22 15:22:56]

Rubberstamp LGTM (i.e. the code in the request limiter looks trivial & tightly
tied to the permission bubble manager, so I'll go along with the review for that
code).

[Greg Billock, 2014-04-24 18:12:37]

On 2014/04/22 15:22:56, rdsmith wrote:
> Rubberstamp LGTM (i.e. the code in the request limiter looks trivial & tightly
> tied to the permission bubble manager, so I'll go along with the review for
that
> code).

ping markusheintz

[markusheintz_, 2014-04-28 15:21:04]

On 2014/04/24 18:12:37, Greg Billock wrote:
> On 2014/04/22 15:22:56, rdsmith wrote:
> > Rubberstamp LGTM (i.e. the code in the request limiter looks trivial &
tightly
> > tied to the permission bubble manager, so I'll go along with the review for
> that
> > code).
> 
> ping markusheintz

LGTM

[Greg Billock, 2014-04-28 15:22:35]

The CQ bit was checked by gbillock@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:22:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/243543003/10001

[commit-bot: I haz the power, 2014-04-28 16:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:44:19]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Greg Billock, 2014-04-28 17:15:28]

The CQ bit was checked by gbillock@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:16:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/243543003/10001

[Paweł Hajdan Jr., 2014-04-29 10:03:55]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-04-29 10:04:00]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-04-29 10:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/243543003/10001

[commit-bot: I haz the power, 2014-04-29 11:53:47]

Change committed as 266855

[Michael Achenbach, 2014-04-29 13:05:49]

A revert of this CL has been created in
https://codereview.chromium.org/260373002/ by machenbach@chromium.org.

The reason for reverting is: This breaks Linux ASAN, heap use after free:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

[Greg Billock, 2014-04-29 19:29:43]

On 2014/04/29 13:05:49, Michael Achenbach wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/260373002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: This breaks Linux ASAN, heap use after free:
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

Manually tested ASAN build successfully. Going to wait a bit more and see if the
trybots get scheduled.

[Greg Billock, 2014-04-30 00:08:20]

The CQ bit was checked by gbillock@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:11:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/243543003/30001

[commit-bot: I haz the power, 2014-04-30 05:52:07]

Change committed as 267099