Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 243543003: [WebsiteSettings] Update permission bubble manager policy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: weak ptr Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/ui/website_settings/mock_permission_bubble_request.h" 8 #include "chrome/browser/ui/website_settings/mock_permission_bubble_request.h"
9 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h" 9 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
10 #include "chrome/browser/ui/website_settings/permission_bubble_request.h" 10 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 : ChromeRenderViewHostTestHarness(), 63 : ChromeRenderViewHostTestHarness(),
64 request1_("test1"), 64 request1_("test1"),
65 request2_("test2") {} 65 request2_("test2") {}
66 virtual ~PermissionBubbleManagerTest() {} 66 virtual ~PermissionBubbleManagerTest() {}
67 67
68 virtual void SetUp() OVERRIDE { 68 virtual void SetUp() OVERRIDE {
69 ChromeRenderViewHostTestHarness::SetUp(); 69 ChromeRenderViewHostTestHarness::SetUp();
70 SetContents(CreateTestWebContents()); 70 SetContents(CreateTestWebContents());
71 71
72 manager_.reset(new PermissionBubbleManager(web_contents())); 72 manager_.reset(new PermissionBubbleManager(web_contents()));
73 manager_->SetCoalesceIntervalForTesting(0);
74 } 73 }
75 74
76 virtual void TearDown() OVERRIDE { 75 virtual void TearDown() OVERRIDE {
77 manager_.reset(); 76 manager_.reset();
78 ChromeRenderViewHostTestHarness::TearDown(); 77 ChromeRenderViewHostTestHarness::TearDown();
79 } 78 }
80 79
81 void ToggleAccept(int index, bool value) { 80 void ToggleAccept(int index, bool value) {
82 manager_->ToggleAccept(index, value); 81 manager_->ToggleAccept(index, value);
83 } 82 }
84 83
85 void Accept() { 84 void Accept() {
86 manager_->Accept(); 85 manager_->Accept();
87 } 86 }
88 87
89 void WaitForCoalescing() { 88 void WaitForCoalescing() {
89 manager_->DocumentOnLoadCompletedInMainFrame(0);
90 base::MessageLoop::current()->RunUntilIdle(); 90 base::MessageLoop::current()->RunUntilIdle();
91 } 91 }
92 92
93 virtual void NavigationEntryCommitted( 93 virtual void NavigationEntryCommitted(
94 const content::LoadCommittedDetails& details) { 94 const content::LoadCommittedDetails& details) {
95 manager_->NavigationEntryCommitted(details); 95 manager_->NavigationEntryCommitted(details);
96 } 96 }
97 97
98 protected: 98 protected:
99 MockPermissionBubbleRequest request1_; 99 MockPermissionBubbleRequest request1_;
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 manager_->AddRequest(&request1_); 230 manager_->AddRequest(&request1_);
231 WaitForCoalescing(); 231 WaitForCoalescing();
232 manager_->AddRequest(&request2_); 232 manager_->AddRequest(&request2_);
233 233
234 EXPECT_TRUE(view_.shown_); 234 EXPECT_TRUE(view_.shown_);
235 ASSERT_EQ(1u, view_.permission_requests_.size()); 235 ASSERT_EQ(1u, view_.permission_requests_.size());
236 EXPECT_EQ(&request1_, view_.permission_requests_[0]); 236 EXPECT_EQ(&request1_, view_.permission_requests_[0]);
237 237
238 view_.Hide(); 238 view_.Hide();
239 Accept(); 239 Accept();
240 EXPECT_FALSE(view_.shown_); 240 WaitForCoalescing();
241 241
242 WaitForCoalescing();
243 EXPECT_TRUE(view_.shown_); 242 EXPECT_TRUE(view_.shown_);
244 ASSERT_EQ(1u, view_.permission_requests_.size()); 243 ASSERT_EQ(1u, view_.permission_requests_.size());
245 EXPECT_EQ(&request2_, view_.permission_requests_[0]); 244 EXPECT_EQ(&request2_, view_.permission_requests_[0]);
246 } 245 }
247 246
248 TEST_F(PermissionBubbleManagerTest, TestAddDuplicateRequest) { 247 TEST_F(PermissionBubbleManagerTest, TestAddDuplicateRequest) {
249 manager_->SetView(&view_); 248 manager_->SetView(&view_);
250 manager_->AddRequest(&request1_); 249 manager_->AddRequest(&request1_);
251 manager_->AddRequest(&request2_); 250 manager_->AddRequest(&request2_);
252 manager_->AddRequest(&request1_); 251 manager_->AddRequest(&request1_);
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 NavigateAndCommit(GURL("http://www.google.com/")); 318 NavigateAndCommit(GURL("http://www.google.com/"));
320 manager_->SetView(&view_); 319 manager_->SetView(&view_);
321 manager_->AddRequest(&request1_); 320 manager_->AddRequest(&request1_);
322 WaitForCoalescing(); 321 WaitForCoalescing();
323 manager_->AddRequest(&request2_); 322 manager_->AddRequest(&request2_);
324 323
325 EXPECT_TRUE(view_.shown_); 324 EXPECT_TRUE(view_.shown_);
326 ASSERT_EQ(1u, view_.permission_requests_.size()); 325 ASSERT_EQ(1u, view_.permission_requests_.size());
327 326
328 NavigateAndCommit(GURL("http://www2.google.com/")); 327 NavigateAndCommit(GURL("http://www2.google.com/"));
328 WaitForCoalescing();
329 329
330 EXPECT_FALSE(view_.shown_);
331 EXPECT_TRUE(request1_.finished()); 330 EXPECT_TRUE(request1_.finished());
332 EXPECT_TRUE(request2_.finished()); 331 EXPECT_TRUE(request2_.finished());
333 } 332 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698