Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 243533002: Fix aggressive RELEASE_ASSERTs in Resource (Closed)

Created:
6 years, 8 months ago by Alpha Left Google
Modified:
6 years, 8 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

Fix aggressive RELEASE_ASSERTs in Resource I added RELEASE_ASSERTs in my last patch what are found to be too aggressive. Change them back to ASSERTs and add preventive measures. BUG=352043 R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171972

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix debug build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Source/core/fetch/Resource.cpp View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alpha Left Google
6 years, 8 months ago (2014-04-18 18:40:23 UTC) #1
Nate Chapin
https://codereview.chromium.org/243533002/diff/1/Source/core/fetch/Resource.cpp File Source/core/fetch/Resource.cpp (right): https://codereview.chromium.org/243533002/diff/1/Source/core/fetch/Resource.cpp#newcode594 Source/core/fetch/Resource.cpp:594: if (ResourceCallback::callbackHandler()->isScheduled(this) && m_clientsAwaitingCallback.isEmpty()) { Style nit: the curly ...
6 years, 8 months ago (2014-04-18 18:43:46 UTC) #2
Nate Chapin
On 2014/04/18 18:43:46, Nate Chapin wrote: > https://codereview.chromium.org/243533002/diff/1/Source/core/fetch/Resource.cpp > File Source/core/fetch/Resource.cpp (right): > > https://codereview.chromium.org/243533002/diff/1/Source/core/fetch/Resource.cpp#newcode594 ...
6 years, 8 months ago (2014-04-18 18:43:56 UTC) #3
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 8 months ago (2014-04-18 19:35:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/243533002/20001
6 years, 8 months ago (2014-04-18 19:36:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 20:57:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-18 20:57:30 UTC) #7
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 8 months ago (2014-04-18 20:58:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/243533002/20001
6 years, 8 months ago (2014-04-18 20:58:19 UTC) #9
Alpha Left Google
6 years, 8 months ago (2014-04-18 21:16:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r171972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698