bindings: Set strong reference from PerformanceObserver to callback

bindings: Set strong reference from PerformanceObserver to callback

Otherwise the callback can be garbage-collected. This is a tentative
solution until TraceWrapper is fully implemented.

BUG=658030
Committed: https://crrev.com/cb168398aeefebfb5bf8cb39aa9e82b1d47c7b01
Cr-Commit-Position: refs/heads/master@{#426753}

[bashi, 2016-10-21 05:26:29]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:26:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-10-21 05:28:12]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2016-10-21 05:28:12]

PTAL

Using private property is easier than using [Custom=visitDOMWrapper] in this
case.

[haraken, 2016-10-21 06:42:56]

LGTM

Can we add a test for this?

[haraken, 2016-10-21 06:44:14]

Nit: I'd prefer using visitDOMWrapper since it makes the translation to
traceWrapper more straightforward though.

[bashi, 2016-10-21 07:04:52]

Added test.

Agreed visitDOMWrapper is better, but until traceWrapper is fully implemented,
it's not as good as it should be because we have to write custom bindings
anyway.

[bashi, 2016-10-21 07:05:09]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-10-21 07:05:09]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2435263002/#ps20001
(title: "Add test")

[commit-bot: I haz the power, 2016-10-21 07:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 08:46:15]

Committed patchset #2 (id:20001)

[haraken, 2016-10-21 08:48:33]

haraken@chromium.org changed reviewers:
+ mlippautz@chromium.org

[haraken, 2016-10-21 08:48:33]

+Michael

We need to support this in traceWrapper.

[commit-bot: I haz the power, 2016-10-21 13:28:16]

Description was changed from

==========
bindings: Set strong reference from PerformanceObserver to callback

Otherwise the callback can be garbage-collected. This is a tentative
solution until TraceWrapper is fully implemented.

BUG=658030
==========

to

==========
bindings: Set strong reference from PerformanceObserver to callback

Otherwise the callback can be garbage-collected. This is a tentative
solution until TraceWrapper is fully implemented.

BUG=658030

Committed: https://crrev.com/cb168398aeefebfb5bf8cb39aa9e82b1d47c7b01
Cr-Commit-Position: refs/heads/master@{#426753}
==========

[commit-bot: I haz the power, 2016-10-21 13:28:16]

Patchset 2 (id:??) landed as
https://crrev.com/cb168398aeefebfb5bf8cb39aa9e82b1d47c7b01
Cr-Commit-Position: refs/heads/master@{#426753}