Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

Issue 2435263002: bindings: Set strong reference from PerformanceObserver to callback (Closed)
Patch Set: Add test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/performance/performance-observer-callback-after-gc.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
index dcd40e8782fd2c09179610332f124e363629d4bc..b1ed580cbff085afa7ab3ca495dd57ec72319cba 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
@@ -10,6 +10,7 @@
#include "bindings/core/v8/V8DOMWrapper.h"
#include "bindings/core/v8/V8GCController.h"
#include "bindings/core/v8/V8Performance.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "core/timing/DOMWindowPerformance.h"
#include "core/timing/PerformanceObserver.h"
@@ -48,12 +49,18 @@ void V8PerformanceObserver::constructorCustom(
"The callback provided as parameter 1 is not a function."));
return;
}
- PerformanceObserverCallback* callback = PerformanceObserverCallback::create(
- info.GetIsolate(), v8::Local<v8::Function>::Cast(info[0]));
+ v8::Local<v8::Function> v8Callback = v8::Local<v8::Function>::Cast(info[0]);
+ PerformanceObserverCallback* callback =
+ PerformanceObserverCallback::create(info.GetIsolate(), v8Callback);
PerformanceObserver* observer = PerformanceObserver::create(
ScriptState::forReceiverObject(info), performance, callback);
+ // TODO(bashi): Don't set private property (and remove this custom
+ // constructor) when we can call setWrapperReference() correctly.
+ // crbug.com/468240.
+ V8PrivateProperty::getPerformanceObserverCallback(info.GetIsolate())
+ .set(info.GetIsolate()->GetCurrentContext(), wrapper, v8Callback);
v8SetReturnValue(info,
V8DOMWrapper::associateObjectWithWrapper(
info.GetIsolate(), observer, &wrapperTypeInfo, wrapper));
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/performance/performance-observer-callback-after-gc.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698