third_party/WebKit/Source/modules/presentation/PresentationConnection.h - Issue 2435243002: [Presentation API] add 'connecting' state to WebPresentationConnectionState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

Issue 2435243002: [Presentation API] add 'connecting' state to WebPresentationConnectionState (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp » ('j') | third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

index 323c6a38f42c7c8e9b28cb3241ff5f630d0f2e07..ea526a75d36bf47ae80aa6560f31f2430aaeaba9 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

@@ -77,7 +77,7 @@ class PresentationConnection final : public EventTargetWithInlineData,

// this connection.

bool matches(WebPresentationConnectionClient*) const;

- // Notifies the connection about its state change.

+ // Queue a task to notifies the connection about its state change.

imcheng 2016/10/21 23:58:15 Queues a task to notify...

zhaobin 2016/10/24 19:42:39 reverted.

void didChangeState(WebPresentationConnectionState);

// Notifies the connection about its state change to 'closed'.

@@ -113,6 +113,7 @@ class PresentationConnection final : public EventTargetWithInlineData,

// Callbacks invoked from BlobLoader.

void didFinishLoadingBlob(DOMArrayBuffer*);

void didFailLoadingBlob(FileError::ErrorCode);

+ void didChangeStateInternal(WebPresentationConnectionState);

imcheng 2016/10/21 23:58:15 nit: blank line before this to separate it from th

zhaobin 2016/10/24 19:42:39 reverted.

// Cancel loads and pending messages when the connection is closed.

void tearDown();