[Presentation API] add 'connecting' state to WebPresentationConnectionState

third_party/WebKit/Source/modules/presentation/PresentationConnection.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PresentationConnection_h
 #define PresentationConnection_h
 
 #include "core/events/EventTarget.h"
 #include "core/fileapi/Blob.h"
 #include "core/fileapi/FileError.h"
@@ skipping 59 matching lines @@
 
   DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(connect);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(terminate);
 
   // Returns true if and only if the WebPresentationConnectionClient represents
   // this connection.
   bool matches(WebPresentationConnectionClient*) const;
 
-  // Notifies the connection about its state change.
+  // Queue a task to notifies the connection about its state change.

[imcheng, 2016/10/21 23:58:15]

Queues a task to notify...

[zhaobin, 2016/10/24 19:42:39]

reverted.

   void didChangeState(WebPresentationConnectionState);
 
   // Notifies the connection about its state change to 'closed'.
   void didClose(WebPresentationConnectionCloseReason, const String& message);
 
   // Notifies the presentation about new message.
   void didReceiveTextMessage(const String& message);
   void didReceiveBinaryMessage(const uint8_t* data, size_t length);
 
  protected:
@@ skipping 15 matching lines @@
   class Message;
 
   PresentationConnection(LocalFrame*, const String& id, const KURL&);
 
   bool canSendMessage(ExceptionState&);
   void handleMessageQueue();
 
   // Callbacks invoked from BlobLoader.
   void didFinishLoadingBlob(DOMArrayBuffer*);
   void didFailLoadingBlob(FileError::ErrorCode);
+  void didChangeStateInternal(WebPresentationConnectionState);

[imcheng, 2016/10/21 23:58:15]

nit: blank line before this to separate it from the blob loader callbacks

[zhaobin, 2016/10/24 19:42:39]

reverted.

 
   // Cancel loads and pending messages when the connection is closed.
   void tearDown();
 
   String m_id;
   KURL m_url;
   WebPresentationConnectionState m_state;
 
   // For Blob data handling.
   Member<BlobLoader> m_blobLoader;
   HeapDeque<Member<Message>> m_messages;
 
   BinaryType m_binaryType;
 };
 
 }  // namespace blink
 
 #endif  // PresentationConnection_h