Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js

Issue 243523003: Fire window.onerror for uncaught IndexedDB errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove FIXMEs Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js
diff --git a/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js b/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js
index 1b460adbbe115343ac764c7db0a87a8b06cfc3e5..94996e891a8029c3779e21d1113a323df8446c37 100644
--- a/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js
+++ b/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js
@@ -18,12 +18,21 @@ function test()
var sawUpgradeNeeded = false;
var sawVersionChange = false;
var sawDeleteBlocked = false;
+var sawOpenError = false;
function initiallyDeleted(evt) {
preamble(evt);
evalAndLog("request = indexedDB.open(dbname, 1)");
request.onupgradeneeded = upgradeNeededCallback;
request.onsuccess = unexpectedSuccessCallback;
+ request.onerror = openError;
+}
+
+function openError(evt) {
+ preamble(evt);
+ shouldBeTrue("sawVersionChange");
+ evalAndLog("sawOpenError = true");
+ evt.preventDefault();
}
function upgradeNeededCallback(evt)
@@ -62,7 +71,7 @@ function deleteBlockedCallback(evt)
function deleteSuccessCallback(evt)
{
preamble(evt);
- shouldBeTrue("sawVersionChange");
+ shouldBeTrue("sawOpenError");
debug("FIXME: Blocked events shouldn't fire if connections close in versionchange handler. http://crbug.com/100123");
shouldBeFalse("sawDeleteBlocked");
shouldBeTrue("sawUpgradeNeeded");

Powered by Google App Engine
This is Rietveld 408576698