Fire window.onerror for uncaught IndexedDB errors

LayoutTests/storage/indexeddb/resources/odd-strings.js

Index: LayoutTests/storage/indexeddb/resources/odd-strings.js
diff --git a/LayoutTests/storage/indexeddb/resources/odd-strings.js b/LayoutTests/storage/indexeddb/resources/odd-strings.js
index 4f02b9056d3ee6b6947ae417bc0cf57dc0c70dbe..ee9762b2f48e44b0c76a1df9d74f115e2f0a9781 100644
--- a/LayoutTests/storage/indexeddb/resources/odd-strings.js
+++ b/LayoutTests/storage/indexeddb/resources/odd-strings.js
@@ -36,9 +36,9 @@ function openNextDatabase()
 {
     debug("opening a database named " + testData[nextToOpen].description);
     request = evalAndLog("indexedDB.open(testData[nextToOpen].name, 1)");
-    request.onsuccess = unexpectedSuccessCallback;
     request.onblocked = unexpectedBlockedCallback;
     request.onupgradeneeded = addAKey;
+    request.onsuccess = closeDatabase;

[ericu, 2014/06/19 00:54:05]

Can you talk me through this change?  Why are we now expecting success here?

[jsbell, 2014/06/19 01:13:24]

Previously, the test was closing the database in the 'success' callback of a
request made during the upgrade (`request.onsuccess = closeDatabase;`, below).
Closing the database during the upgrade sequence causes the open request to
fail; this was previously silent but now generates window.onerror spew.

Since that complex flow was completely irrelevant to the test itself, I
simplified the flow - closing the database is now done when the open succeeds.
The alternative was to leave that flow intact, but e.preventDefault() or
expectError().

[ericu, 2014/06/19 01:18:40]

OK.

 }
 
 function addAKey()
@@ -48,7 +48,6 @@ function addAKey()
     evalAndLog("index = objectStore.createIndex(testData[nextToOpen].name, 'keyPath');");
     evalAndLog("key = testData[nextToOpen].name");
     evalAndLog("request = objectStore.add(key, key);");
-    request.onsuccess = closeDatabase;
     request.onerror = unexpectedErrorCallback;
 }