Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2434873003: Fix <object data=> YouTube Flash rewrites. (Closed)

Created:
4 years, 2 months ago by whywhat
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix <object data=> YouTube Flash rewrites. Some YouTube videos are embedded via <object data="http://www.youtube.com/v/AABBCCDD">. Chrome currently only rewrites embeds that use <embed src="http://www.youtube.com/v/AABBCCDD"> The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5 embeds to the HTMLObjectElement (this matches Firefox behavior). Trying to reland https://codereview.chromium.org/2416253002. Split the browser test into 10 separate test cases trying to avoid OOM on Debug ChromiumOS builder. BUG=655988 TEST=manual + updated browser tests Review-Url: https://chromiumcodereview.appspot.com/2424293002 Cr-Commit-Position: refs/heads/master@{#426223} (cherry picked from commit 3efdec3c23c4fb82b88803d65daf114beae5553d)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -55 lines) Patch
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 2 chunks +94 lines, -54 lines 0 comments Download
M chrome/test/data/flash_embeds.html View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434873003/1
4 years, 2 months ago (2016-10-19 21:44:43 UTC) #2
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 21:44:44 UTC) #4
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698