Fix <object data=> YouTube Flash rewrites.

Fix <object data=> YouTube Flash rewrites.

Some YouTube videos are embedded via <object data="http://www.youtube.com/v/AABBCCDD">.
Chrome currently only rewrites embeds that use <embed src="http://www.youtube.com/v/AABBCCDD">
The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5 embeds to the
HTMLObjectElement (this matches Firefox behavior).

BUG=655988
TEST=manual + updated browser tests

Committed: https://crrev.com/d5ee1a98ea763ab6231e71ffa03f55290a20c837
Cr-Commit-Position: refs/heads/master@{#425704}

[whywhat, 2016-10-14 16:52:49]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2016-10-14 16:52:49]

PTaL

[whywhat, 2016-10-14 16:52:56]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 16:53:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:15:57]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-10-14 23:53:55]

lgtm

Thanks for fixing this! :)

[whywhat, 2016-10-15 00:16:26]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:16:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:25:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[whywhat, 2016-10-15 00:38:33]

avayvod@chromium.org changed reviewers:
+ foolip@chromium.org

[whywhat, 2016-10-15 00:38:33]

+foolip for OWNERS

[foolip, 2016-10-15 21:04:52]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-15 21:04:53]

lgtm

[commit-bot: I haz the power, 2016-10-15 21:04:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 21:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 21:10:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[whywhat, 2016-10-16 03:32:29]

avayvod@chromium.org changed reviewers:
+ jochen@chromium.org

[whywhat, 2016-10-16 03:32:30]

+jochen for the rest of OWNERS

chrome/renderer?

[jochen (gone - plz use gerrit), 2016-10-17 09:54:05]

lgtm

[whywhat, 2016-10-17 15:21:55]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-10-17 15:22:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 17:07:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-17 17:09:18]

Description was changed from

==========
Fix <object data=> YouTube Flash rewrites.

Some YouTube videos are embedded via <object
data="http://www.youtube.com/v/AABBCCDD">.
Chrome currently only rewrites embeds that use <embed
src="http://www.youtube.com/v/AABBCCDD">
The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5
embeds to the
HTMLObjectElement (this matches Firefox behavior).

BUG=655988
TEST=manual + updated browser tests
==========

to

==========
Fix <object data=> YouTube Flash rewrites.

Some YouTube videos are embedded via <object
data="http://www.youtube.com/v/AABBCCDD">.
Chrome currently only rewrites embeds that use <embed
src="http://www.youtube.com/v/AABBCCDD">
The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5
embeds to the
HTMLObjectElement (this matches Firefox behavior).

BUG=655988
TEST=manual + updated browser tests

Committed: https://crrev.com/d5ee1a98ea763ab6231e71ffa03f55290a20c837
Cr-Commit-Position: refs/heads/master@{#425704}
==========

[commit-bot: I haz the power, 2016-10-17 17:09:20]

Patchset 1 (id:??) landed as
https://crrev.com/d5ee1a98ea763ab6231e71ffa03f55290a20c837
Cr-Commit-Position: refs/heads/master@{#425704}

[joedow, 2016-10-17 20:45:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2425623003/ by joedow@chromium.org.

The reason for reverting is: This CL appears to be causing failures on
ChromiumOS:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...


browser_tests on Ubuntu-12.04 browser_tests on Ubuntu-12.04

678 disabled
10 flaky
failed 1

failures:
ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbed

.