Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2673)

Unified Diff: base/test/test_pending_task.h

Issue 2434783002: Use OnceClosure in TestPendingTask (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/test_pending_task.h
diff --git a/base/test/test_pending_task.h b/base/test/test_pending_task.h
index 2dbdb7eeccbdcc1927dca53114258f83eb06e477..a4610911ff5739f123b22c9cfa3c3390dec4ed53 100644
--- a/base/test/test_pending_task.h
+++ b/base/test/test_pending_task.h
@@ -21,7 +21,7 @@ struct TestPendingTask {
enum TestNestability { NESTABLE, NON_NESTABLE };
TestPendingTask();
- TestPendingTask(const TestPendingTask& other);
+ TestPendingTask(TestPendingTask&& other);
TestPendingTask(const tracked_objects::Location& location,
const Closure& task,
TimeTicks post_time,
@@ -29,6 +29,8 @@ struct TestPendingTask {
TestNestability nestability);
~TestPendingTask();
+ TestPendingTask& operator=(TestPendingTask&& other);
+
// Returns post_time + delay.
TimeTicks GetTimeToRun() const;
@@ -51,7 +53,7 @@ struct TestPendingTask {
bool ShouldRunBefore(const TestPendingTask& other) const;
tracked_objects::Location location;
- Closure task;
+ OnceClosure task;
TimeTicks post_time;
TimeDelta delay;
TestNestability nestability;
@@ -61,6 +63,8 @@ struct TestPendingTask {
void AsValueInto(base::trace_event::TracedValue* state) const;
std::unique_ptr<base::trace_event::ConvertableToTraceFormat> AsValue() const;
std::string ToString() const;
+
+ DISALLOW_COPY_AND_ASSIGN(TestPendingTask);
danakj 2016/10/20 20:07:46 private
tzik 2016/10/27 08:20:49 Done.
};
// gtest helpers which allow pretty printing of the tasks, very useful in unit

Powered by Google App Engine
This is Rietveld 408576698