Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: base/test/test_pending_task.h

Issue 2434783002: Use OnceClosure in TestPendingTask (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TEST_TEST_PENDING_TASK_H_ 5 #ifndef BASE_TEST_TEST_PENDING_TASK_H_
6 #define BASE_TEST_TEST_PENDING_TASK_H_ 6 #define BASE_TEST_TEST_PENDING_TASK_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/location.h" 11 #include "base/location.h"
12 #include "base/time/time.h" 12 #include "base/time/time.h"
13 #include "base/trace_event/trace_event_argument.h" 13 #include "base/trace_event/trace_event_argument.h"
14 14
15 namespace base { 15 namespace base {
16 16
17 // TestPendingTask is a helper class for test TaskRunner 17 // TestPendingTask is a helper class for test TaskRunner
18 // implementations. See test_simple_task_runner.h for example usage. 18 // implementations. See test_simple_task_runner.h for example usage.
19 19
20 struct TestPendingTask { 20 struct TestPendingTask {
21 enum TestNestability { NESTABLE, NON_NESTABLE }; 21 enum TestNestability { NESTABLE, NON_NESTABLE };
22 22
23 TestPendingTask(); 23 TestPendingTask();
24 TestPendingTask(const TestPendingTask& other); 24 TestPendingTask(TestPendingTask&& other);
25 TestPendingTask(const tracked_objects::Location& location, 25 TestPendingTask(const tracked_objects::Location& location,
26 const Closure& task, 26 const Closure& task,
27 TimeTicks post_time, 27 TimeTicks post_time,
28 TimeDelta delay, 28 TimeDelta delay,
29 TestNestability nestability); 29 TestNestability nestability);
30 ~TestPendingTask(); 30 ~TestPendingTask();
31 31
32 TestPendingTask& operator=(TestPendingTask&& other);
33
32 // Returns post_time + delay. 34 // Returns post_time + delay.
33 TimeTicks GetTimeToRun() const; 35 TimeTicks GetTimeToRun() const;
34 36
35 // Returns true if this task is nestable and |other| isn't, or if 37 // Returns true if this task is nestable and |other| isn't, or if
36 // this task's time to run is strictly earlier than |other|'s time 38 // this task's time to run is strictly earlier than |other|'s time
37 // to run. 39 // to run.
38 // 40 //
39 // Note that two tasks may both have the same nestability and delay. 41 // Note that two tasks may both have the same nestability and delay.
40 // In that case, the caller must use some other criterion (probably 42 // In that case, the caller must use some other criterion (probably
41 // the position in some queue) to break the tie. Conveniently, the 43 // the position in some queue) to break the tie. Conveniently, the
42 // following STL functions already do so: 44 // following STL functions already do so:
43 // 45 //
44 // - std::min_element 46 // - std::min_element
45 // - std::stable_sort 47 // - std::stable_sort
46 // 48 //
47 // but the following STL functions don't: 49 // but the following STL functions don't:
48 // 50 //
49 // - std::max_element 51 // - std::max_element
50 // - std::sort. 52 // - std::sort.
51 bool ShouldRunBefore(const TestPendingTask& other) const; 53 bool ShouldRunBefore(const TestPendingTask& other) const;
52 54
53 tracked_objects::Location location; 55 tracked_objects::Location location;
54 Closure task; 56 OnceClosure task;
55 TimeTicks post_time; 57 TimeTicks post_time;
56 TimeDelta delay; 58 TimeDelta delay;
57 TestNestability nestability; 59 TestNestability nestability;
58 60
59 // Functions for using test pending task with tracing, useful in unit 61 // Functions for using test pending task with tracing, useful in unit
60 // testing. 62 // testing.
61 void AsValueInto(base::trace_event::TracedValue* state) const; 63 void AsValueInto(base::trace_event::TracedValue* state) const;
62 std::unique_ptr<base::trace_event::ConvertableToTraceFormat> AsValue() const; 64 std::unique_ptr<base::trace_event::ConvertableToTraceFormat> AsValue() const;
63 std::string ToString() const; 65 std::string ToString() const;
66
67 DISALLOW_COPY_AND_ASSIGN(TestPendingTask);
danakj 2016/10/20 20:07:46 private
tzik 2016/10/27 08:20:49 Done.
64 }; 68 };
65 69
66 // gtest helpers which allow pretty printing of the tasks, very useful in unit 70 // gtest helpers which allow pretty printing of the tasks, very useful in unit
67 // testing. 71 // testing.
68 std::ostream& operator<<(std::ostream& os, const TestPendingTask& task); 72 std::ostream& operator<<(std::ostream& os, const TestPendingTask& task);
69 void PrintTo(const TestPendingTask& task, std::ostream* os); 73 void PrintTo(const TestPendingTask& task, std::ostream* os);
70 74
71 } // namespace base 75 } // namespace base
72 76
73 #endif // BASE_TEST_TEST_PENDING_TASK_H_ 77 #endif // BASE_TEST_TEST_PENDING_TASK_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698