Chromium Code Reviews

Issue 2434333005: Introduce method data map in getInstrument (Closed)

Created:
4 years, 2 months ago by rwlbuis
Modified:
4 years, 1 month ago
Reviewers:
please use gerrit instead
CC:
chromium-reviews, rouslan+payments_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce method data map in getInstrument Payments apps can support multiple methods, and each method can have associated data, so instead of passing on method associated data as JSON string, pass a method -> method specific data map. This CL also renames some methods to make it clear if we are dealing with the PaymentApp or PaymentInstrument. BUG=587995 Committed: https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc Cr-Commit-Position: refs/heads/master@{#427068}

Patch Set 1 #

Patch Set 2 : Fix compilation #

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL.
4 years, 2 months ago (2016-10-21 23:54:31 UTC) #4
please use gerrit instead
lgtm
4 years, 1 month ago (2016-10-24 13:46:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434333005/40001
4 years, 1 month ago (2016-10-24 13:51:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-24 14:43:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 14:46:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78d60d3db799ca9a37385f8357901c154451cadc
Cr-Commit-Position: refs/heads/master@{#427068}

Powered by Google App Engine