Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4765)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

Issue 2434333005: Introduce method data map in getInstrument (Closed)
Patch Set: Fix compilation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
index dc4795953278635a2f3711916f0d40ea8ed5a294..02ad404a50d649768fafa73b0af0a49c59725480 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
@@ -20,7 +20,7 @@ public abstract class PaymentInstrument extends PaymentOption {
/**
* The interface for the requester of instrument details.
*/
- public interface DetailsCallback {
+ public interface InstrumentDetailsCallback {
/**
* Called after retrieving instrument details.
*
@@ -40,12 +40,12 @@ public abstract class PaymentInstrument extends PaymentOption {
}
/**
- * Returns the method name for this instrument, e.g., "visa" or "mastercard" in basic card
- * payments: https://w3c.github.io/browser-payment-api/specs/basic-card-payment.html#method-id
+ * Returns a method name for this instrument, e.g., "visa" or "mastercard" in basic card
+ * payments: https://w3c.github.io/webpayments-methods-card/#method-id
*
- * @return The method name for this instrument.
+ * @return The method names for this instrument.
*/
- public abstract String getMethodName();
+ public abstract String getInstrumentMethodName();
/**
* Asynchronously retrieves the instrument details and invokes the callback with the result.
@@ -58,12 +58,12 @@ public abstract class PaymentInstrument extends PaymentOption {
* in test or production key, a merchant identifier, or a public key.
* @param callback The object that will receive the instrument details.
*/
- public abstract void getDetails(String merchantName, String origin, PaymentItem total,
- List<PaymentItem> cart, JSONObject details, DetailsCallback callback);
+ public abstract void getInstrumentDetails(String merchantName, String origin, PaymentItem total,
+ List<PaymentItem> cart, JSONObject details, InstrumentDetailsCallback callback);
/**
* Cleans up any resources held by the payment instrument. For example, closes server
* connections.
*/
- public abstract void dismiss();
+ public abstract void dismissInstrument();
}

Powered by Google App Engine
This is Rietveld 408576698