Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: google_apis/gcm/engine/registration_request.h

Issue 2434243002: GCM Engine: Split up reg/unreg UNKNOWN_ERROR to improve metrics (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/registration_request.h
diff --git a/google_apis/gcm/engine/registration_request.h b/google_apis/gcm/engine/registration_request.h
index cac838d5fa32bed2455578c6093bd2b03c8be118..1b5708ce79d5f45cf64bbc4a60cbcc9b0cc1a900 100644
--- a/google_apis/gcm/engine/registration_request.h
+++ b/google_apis/gcm/engine/registration_request.h
@@ -51,6 +51,10 @@ class GCM_EXPORT RegistrationRequest : public net::URLFetcherDelegate {
HTTP_NOT_OK, // HTTP status was not OK.
NO_RESPONSE_BODY, // No response body.
REACHED_MAX_RETRIES, // Reached maximum number of retries.
+ RESPONSE_PARSING_FAILED, // Registration response parsing failed.
+ INTERNAL_SERVER_ERROR, // Internal server error during request.
+ QUOTA_EXCEEDED, // Registration quota exceeded.
+ TOO_MANY_REGISTRATIONS, // Max registrations per device exceeded.
// NOTE: always keep this entry at the end. Add new status types only
// immediately above this line. Make sure to update the corresponding
// histogram enum accordingly.

Powered by Google App Engine
This is Rietveld 408576698