google_apis/gcm/engine/gcm_unregistration_request_handler.h - Issue 2434243002: GCM Engine: Split up reg/unreg UNKNOWN_ERROR to improve metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/gcm_unregistration_request_handler.h

Issue 2434243002: GCM Engine: Split up reg/unreg UNKNOWN_ERROR to improve metrics (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/gcm_unregistration_request_handler.h

diff --git a/google_apis/gcm/engine/gcm_unregistration_request_handler.h b/google_apis/gcm/engine/gcm_unregistration_request_handler.h

index b5a3b944d3260de55408b451c7890baba8f2f158..162dfbe6096f489b9700457c0f4291a159d67503 100644

--- a/google_apis/gcm/engine/gcm_unregistration_request_handler.h

+++ b/google_apis/gcm/engine/gcm_unregistration_request_handler.h

@@ -20,8 +20,7 @@ class GCM_EXPORT GCMUnregistrationRequestHandler :

// UnregistrationRequest::CustomRequestHandler overrides:

void BuildRequestBody(std::string* body) override;

- UnregistrationRequest::Status ParseResponse(

- const net::URLFetcher* source) override;

+ UnregistrationRequest::Status ParseResponse(std::string response) override;

Nicolas Zea 2016/10/20 21:05:22 make this const ref? (same with other methods now

johnme 2016/11/01 14:15:40 Ahem, must have been a long day. Done.

void ReportUMAs(UnregistrationRequest::Status status,

int retry_count,

base::TimeDelta complete_time) override;