Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.cc

Issue 2434243002: GCM Engine: Split up reg/unreg UNKNOWN_ERROR to improve metrics (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_stats_recorder_impl.cc
diff --git a/components/gcm_driver/gcm_stats_recorder_impl.cc b/components/gcm_driver/gcm_stats_recorder_impl.cc
index 6016d493e0ac25b8d04510ec1b653fbda3fa7660..faa0cc7e8caeb05f04b2eb2d37cb54791ff79653 100644
--- a/components/gcm_driver/gcm_stats_recorder_impl.cc
+++ b/components/gcm_driver/gcm_stats_recorder_impl.cc
@@ -106,6 +106,14 @@ std::string GetRegistrationStatusString(
return "NO_RESPONSE_BODY";
case gcm::RegistrationRequest::REACHED_MAX_RETRIES:
return "REACHED_MAX_RETRIES";
+ case gcm::RegistrationRequest::RESPONSE_PARSING_FAILED:
+ return "RESPONSE_PARSING_FAILED";
+ case gcm::RegistrationRequest::INTERNAL_SERVER_ERROR:
+ return "INTERNAL_SERVER_ERROR";
+ case gcm::RegistrationRequest::QUOTA_EXCEEDED:
+ return "QUOTA_EXCEEDED";
+ case gcm::RegistrationRequest::TOO_MANY_REGISTRATIONS:
+ return "TOO_MANY_REGISTRATIONS";
case gcm::RegistrationRequest::STATUS_COUNT:
NOTREACHED();
break;
@@ -140,6 +148,8 @@ std::string GetUnregistrationStatusString(
return "UNKNOWN_ERROR";
case gcm::UnregistrationRequest::REACHED_MAX_RETRIES:
return "REACHED_MAX_RETRIES";
+ case gcm::UnregistrationRequest::DEVICE_REGISTRATION_ERROR:
+ return "DEVICE_REGISTRATION_ERROR";
case gcm::UnregistrationRequest::UNREGISTRATION_STATUS_COUNT:
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698