gyp: Add support for all big endian platforms

gyp: Add support for all big endian platform

Update config to use icudtb.dat if the byteorder is big
endian, this will work for other big endian platforms
such as PPC and s390.
Original CL for BE support: https://codereview.chromium.org/2162393003

R=jshin@chromium.org
BUG=v8:5567
Committed: https://chromium.googlesource.com/chromium/deps/icu/+/c1a237113f525a1561d4b322d7653e1083f79aaa

[JaideepBajwa, 2016-10-20 01:34:11]

ptal

[jungshik at Google, 2016-10-21 07:54:41]

Thank you for a CL. 

Please, file a new bug against v8 instead of referring to a closed bug and
update BUG line. 

And, gyp support is going away. It'd be best if you can update BUILD.gn in a
single CL. If not, at least add TODO about missing support in BUILD.gn.

[jungshik at Google, 2016-10-21 08:01:04]

https://codereview.chromium.org/2434153002/diff/1/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/2434153002/diff/1/icu.gyp#newcode113
icu.gyp:113: [ 'v8_host_byteorder=="big"', {
Given that gyp is not used any more for chromium. This v8-specific variable is
ok, I guess.

[JaideepBajwa, 2016-10-25 21:07:14]

Description was changed from

==========
gyp: Add support for all big endian platform

Update config to use icudtb.dat if the byteorder is big
endian, this will work for other big endian platforms
such as PPC and s390.
Original CL for BE support: https://codereview.chromium.org/2162393003

R=jshin@chromium.org
BUG=v8:4828
==========

to

==========
gyp: Add support for all big endian platform

Update config to use icudtb.dat if the byteorder is big
endian, this will work for other big endian platforms
such as PPC and s390.
Original CL for BE support: https://codereview.chromium.org/2162393003

R=jshin@chromium.org
BUG=v8:5567
==========

[JaideepBajwa, 2016-10-25 21:25:00]

ptal.
I've updated the bug and added a todo in BUILD.gn (it seems byteorder is not
supported in BUILD.gn yet,
https://cs.chromium.org/chromium/src/v8/BUILD.gn?l=299)

[JaideepBajwa, 2016-11-03 14:33:45]

ptal, this would enable us to build/test v8 with i18n on PPC/s390 big-endian
platform. Thanks.

[jungshik at Google, 2016-11-08 19:28:43]

On 2016/11/03 14:33:45, JaideepBajwa wrote:
> ptal, this would enable us to build/test v8 with i18n on PPC/s390 big-endian
> platform. Thanks.

Ok. Thank you for the update. LGTM

[JaideepBajwa, 2016-11-08 19:44:51]

On 2016/11/08 19:28:43, jungshik at google wrote:
> On 2016/11/03 14:33:45, JaideepBajwa wrote:
> > ptal, this would enable us to build/test v8 with i18n on PPC/s390 big-endian
> > platform. Thanks.
> 
> Ok. Thank you for the update. LGTM

Thank you.

[JaideepBajwa, 2016-11-08 19:47:01]

On 2016/11/08 19:44:51, JaideepBajwa wrote:
> On 2016/11/08 19:28:43, jungshik at google wrote:
> > On 2016/11/03 14:33:45, JaideepBajwa wrote:
> > > ptal, this would enable us to build/test v8 with i18n on PPC/s390
big-endian
> > > platform. Thanks.
> > 
> > Ok. Thank you for the update. LGTM
> 
> Thank you.

I haven't committed to icu project before. How should I commit it?
"Project "icu" does not have a commit queue."

[jungshik at Google, 2016-11-11 21:36:31]

On 2016/11/08 19:47:01, JaideepBajwa wrote:
> On 2016/11/08 19:44:51, JaideepBajwa wrote:
> > On 2016/11/08 19:28:43, jungshik at google wrote:
> > > On 2016/11/03 14:33:45, JaideepBajwa wrote:
> > > > ptal, this would enable us to build/test v8 with i18n on PPC/s390
> big-endian
> > > > platform. Thanks.
> > > 
> > > Ok. Thank you for the update. LGTM
> > 
> > Thank you.
> 
> I haven't committed to icu project before. How should I commit it?
> "Project "icu" does not have a commit queue."

Sorry about that. I'll land it on your behalf.

[jungshik at Google, 2016-11-11 21:39:08]

Description was changed from

==========
gyp: Add support for all big endian platform

Update config to use icudtb.dat if the byteorder is big
endian, this will work for other big endian platforms
such as PPC and s390.
Original CL for BE support: https://codereview.chromium.org/2162393003

R=jshin@chromium.org
BUG=v8:5567
==========

to

==========
gyp: Add support for all big endian platform

Update config to use icudtb.dat if the byteorder is big
endian, this will work for other big endian platforms
such as PPC and s390.
Original CL for BE support: https://codereview.chromium.org/2162393003

R=jshin@chromium.org
BUG=v8:5567

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/c1a237113f525a1561d4b32...
==========

[jungshik at Google, 2016-11-11 21:39:09]

Committed patchset #2 (id:20001) manually as
c1a237113f525a1561d4b322d7653e1083f79aaa (presubmit successful).

[JaideepBajwa, 2016-11-11 21:56:21]

On 2016/11/11 21:36:31, jungshik at google wrote:
> On 2016/11/08 19:47:01, JaideepBajwa wrote:
> > On 2016/11/08 19:44:51, JaideepBajwa wrote:
> > > On 2016/11/08 19:28:43, jungshik at google wrote:
> > > > On 2016/11/03 14:33:45, JaideepBajwa wrote:
> > > > > ptal, this would enable us to build/test v8 with i18n on PPC/s390
> > big-endian
> > > > > platform. Thanks.
> > > > 
> > > > Ok. Thank you for the update. LGTM
> > > 
> > > Thank you.
> > 
> > I haven't committed to icu project before. How should I commit it?
> > "Project "icu" does not have a commit queue."
> 
> Sorry about that. I'll land it on your behalf.

Thank you.

[miran.karic, 2016-11-18 12:10:21]

On 2016/11/11 21:56:21, JaideepBajwa wrote:
> On 2016/11/11 21:36:31, jungshik at google wrote:
> > On 2016/11/08 19:47:01, JaideepBajwa wrote:
> > > On 2016/11/08 19:44:51, JaideepBajwa wrote:
> > > > On 2016/11/08 19:28:43, jungshik at google wrote:
> > > > > On 2016/11/03 14:33:45, JaideepBajwa wrote:
> > > > > > ptal, this would enable us to build/test v8 with i18n on PPC/s390
> > > big-endian
> > > > > > platform. Thanks.
> > > > > 
> > > > > Ok. Thank you for the update. LGTM
> > > > 
> > > > Thank you.
> > > 
> > > I haven't committed to icu project before. How should I commit it?
> > > "Project "icu" does not have a commit queue."
> > 
> > Sorry about that. I'll land it on your behalf.
> 
> Thank you.

This CL has broken things for MIPS. Variable v8_host_byteorder seems to be
problematic, it is initialized in toolchain.gypi with
'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
so this doesn't work when cross compiling, it reads "little" and copies the
wrong ICU data file.
I think I can make the fix CL by checking for mips/mips64 first but I am not
sure that is the best solution.
How do you suggest to proceed?