Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2162393003: fix errors, support data file copy for big endian (Closed)

Created:
4 years, 5 months ago by jungshik at Google
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add big endian support Add a script that generates an assembly file from a .dat file. This is needed for generating big endian assembly file after using icupkg to convert little endian icudtl.dat to big endian icudtb.dat. Also the icu.gyp file is modified so big endian architectures use appropriate files. Patch by miran.karic@ ( https://codereview.chromium.org/1967523002/) with a couple of fixes: 1. Two errors mentioned against PS#9 in the above CL. 2. Support copying icu data file for Big Endian targets. Besides, icudtb.dat was added to common. icudtb.dat was created by running 'icupkg -tb icudt56l.dat icudt56b.dat' and renaming icudt56b.dat to icudtb.dat. BUG=v8:4828 TEST='d8' is built correct with icu_use_data_file set to either 0 or 1. TEST=run `GYP_DEFINES="target_arch=mips" ./gypfiles/gyp_v8` and make sure that ninja files use 'b' data/assembly file for Big Endian. Committed: https://chromium.googlesource.com/chromium/deps/icu/+/e7d37b698c390bcf6de080aeb0a9fbadc952287b

Patch Set 1 #

Patch Set 2 : update icudtb.dat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -10 lines) Patch
A + common/icudtb.dat View 1 Binary file 0 comments Download
M icu.gyp View 7 chunks +89 lines, -10 lines 0 comments Download
A scripts/make_data_assembly.py View 1 chunk +73 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (3 generated)
jungshik at Google
4 years, 5 months ago (2016-07-21 21:02:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e7d37b698c390bcf6de080aeb0a9fbadc952287b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698