|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by Sam McNally Modified:
4 years, 1 month ago Reviewers:
jam CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove uses of AttachmentBroker from //content and //components/nacl.
The browser process and its descendents now use ChannelMojo for all
Channels; ChannelMojo relies on the underlying mojo message pipe to pass
attachments over a channel. Therefore, AttachmentBroker is no longer
needed ther. This CL removes all use of AttachmentBroker from the
browser process and its descendents.
BUG=659448
Committed: https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0
Cr-Commit-Position: refs/heads/master@{#427786}
Patch Set 1 : #
Messages
Total messages: 41 (36 generated)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Description was changed from ========== Remove uses of AttachmentBroker from //content and //components/nacl. BUG=604282 ========== to ========== Remove uses of AttachmentBroker from //content and //components/nacl. BUG=659448 ==========
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Remove uses of AttachmentBroker from //content and //components/nacl. BUG=659448 ========== to ========== Remove uses of AttachmentBroker from //content and //components/nacl. The browser process and its descendents now use ChannelMojo for all Channels; ChannelMojo relies on the underlying mojo message pipe to pass attachments over a channel. Therefore, AttachmentBroker is no longer needed ther. This CL removes all use of AttachmentBroker from the browser process and its descendents. BUG=659448 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sammc@chromium.org changed reviewers: + jam@chromium.org
lgtm
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove uses of AttachmentBroker from //content and //components/nacl. The browser process and its descendents now use ChannelMojo for all Channels; ChannelMojo relies on the underlying mojo message pipe to pass attachments over a channel. Therefore, AttachmentBroker is no longer needed ther. This CL removes all use of AttachmentBroker from the browser process and its descendents. BUG=659448 ========== to ========== Remove uses of AttachmentBroker from //content and //components/nacl. The browser process and its descendents now use ChannelMojo for all Channels; ChannelMojo relies on the underlying mojo message pipe to pass attachments over a channel. Therefore, AttachmentBroker is no longer needed ther. This CL removes all use of AttachmentBroker from the browser process and its descendents. BUG=659448 Committed: https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0 Cr-Commit-Position: refs/heads/master@{#427786} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0 Cr-Commit-Position: refs/heads/master@{#427786} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
