Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2434103002: Remove uses of AttachmentBroker from //content and //components/nacl. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of AttachmentBroker from //content and //components/nacl. The browser process and its descendents now use ChannelMojo for all Channels; ChannelMojo relies on the underlying mojo message pipe to pass attachments over a channel. Therefore, AttachmentBroker is no longer needed ther. This CL removes all use of AttachmentBroker from the browser process and its descendents. BUG=659448 Committed: https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0 Cr-Commit-Position: refs/heads/master@{#427786}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -103 lines) Patch
M components/nacl/broker/nacl_broker_listener.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 5 chunks +0 lines, -28 lines 0 comments Download
M content/child/child_thread_impl.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M content/common/child_process_host_impl.cc View 4 chunks +1 line, -30 lines 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 41 (36 generated)
Sam McNally
4 years, 1 month ago (2016-10-26 06:54:21 UTC) #35
jam
lgtm
4 years, 1 month ago (2016-10-26 15:45:31 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434103002/60001
4 years, 1 month ago (2016-10-26 21:00:11 UTC) #38
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 1 month ago (2016-10-26 21:07:39 UTC) #39
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:09:05 UTC) #41
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0
Cr-Commit-Position: refs/heads/master@{#427786}

Powered by Google App Engine
This is Rietveld 408576698