Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2434103002: Remove uses of AttachmentBroker from //content and //components/nacl. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index bd548ac0cd443e251eecf2204df6a4e5648fb09f..f3dacaaec06187627a0cc7986797f4d5f62a8592 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -166,8 +166,6 @@
#include "gpu/command_buffer/client/gpu_switches.h"
#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/command_buffer/service/gpu_switches.h"
-#include "ipc/attachment_broker.h"
-#include "ipc/attachment_broker_privileged.h"
#include "ipc/ipc.mojom.h"
#include "ipc/ipc_channel.h"
#include "ipc/ipc_channel_mojo.h"
@@ -722,19 +720,6 @@ RenderProcessHostImpl::RenderProcessHostImpl(
AddObserver(BootstrapSandboxManager::GetInstance());
#endif
-#if USE_ATTACHMENT_BROKER
- // Construct the privileged attachment broker early in the life cycle of a
- // render process. This ensures that when a test is being run in one of the
- // single process modes, the global attachment broker is the privileged
- // attachment broker, rather than an unprivileged attachment broker.
-#if defined(OS_MACOSX)
- IPC::AttachmentBrokerPrivileged::CreateBrokerIfNeeded(
- MachBroker::GetInstance());
-#else
- IPC::AttachmentBrokerPrivileged::CreateBrokerIfNeeded();
-#endif // defined(OS_MACOSX)
-#endif // USE_ATTACHMENT_BROKER
-
InitializeChannelProxy();
}
@@ -785,11 +770,6 @@ RenderProcessHostImpl::~RenderProcessHostImpl() {
gpu_observer_registered_ = false;
}
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->DeregisterCommunicationChannel(
- channel_.get());
-#endif
-
is_dead_ = true;
UnregisterHost(GetID());
@@ -994,10 +974,6 @@ void RenderProcessHostImpl::InitializeChannelProxy() {
#endif // OS_ANDROID
if (!channel_)
channel_.reset(new IPC::ChannelProxy(this, io_task_runner.get()));
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->RegisterCommunicationChannel(
- channel_.get(), io_task_runner);
-#endif
channel_->Init(std::move(channel_factory), true /* create_pipe_now */);
// Note that Channel send is effectively paused and unpaused at various points
@@ -1027,10 +1003,6 @@ void RenderProcessHostImpl::ResetChannelProxy() {
if (!channel_)
return;
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->DeregisterCommunicationChannel(
- channel_.get());
-#endif
channel_.reset();
channel_connected_ = false;
}
« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698