chrome/browser/ui/website_settings/website_settings.h - Issue 2434083002: Expand WebsiteSettings histograms for HTTP-bad

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 2434083002: Expand WebsiteSettings histograms for HTTP-bad (Closed)

Patch Set: isherman comments and related cleanup Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/website_settings/website_settings.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_	5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_

6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_	6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/strings/string16.h"	9 #include "base/strings/string16.h"

10 #include "chrome/browser/content_settings/tab_specific_content_settings.h"	10 #include "chrome/browser/content_settings/tab_specific_content_settings.h"

(...skipping 218 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
229 HostContentSettingsMap* content_settings_;	229 HostContentSettingsMap* content_settings_;

230	230

231 // Service for managing SSL error page bypasses. Used to revoke bypass	231 // Service for managing SSL error page bypasses. Used to revoke bypass

232 // decisions by users.	232 // decisions by users.

233 ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_;	233 ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_;

234	234

235 bool did_revoke_user_ssl_decisions_;	235 bool did_revoke_user_ssl_decisions_;

236	236

237 Profile* profile_;	237 Profile* profile_;

238	238

	239 security_state::SecurityStateModel::SecurityLevel security_level_ =

	240 security_state::SecurityStateModel::NONE;
	raymes 2016/10/24 02:58:50 Oh, I just asked a reviewer to use the initializer Oh, I just asked a reviewer to use the initializer list in https://codereview.chromium.org/2440183002/diff/1/chrome/browser/ui/website_s... It would be nice if we had a style guide decision on this. I tend like having all the initializations in one place rather than having to examine 2 locations in the code, which I tend to see as more bug prone, but I know there are arguments for and against. estark 2016/10/24 03:06:46 Done. Show quoted text On 2016/10/24 02:58:50, raymes wrote: > Oh, I just asked a reviewer to use the initializer list in > https://codereview.chromium.org/2440183002/diff/1/chrome/browser/ui/website_s... > > It would be nice if we had a style guide decision on this. I tend like having > all the initializations in one place rather than having to examine 2 locations > in the code, which I tend to see as more bug prone, but I know there are > arguments for and against. Done.
	241

239 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);	242 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);

240 };	243 };

241	244

242 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_	245 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_

OLD	NEW