Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
index 21cd0d9c22bd68dd44947c440f8390409e47ce07..067997bec7b47c928cf75e3a423dff03cbfa849f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
@@ -151,10 +151,10 @@ void V8V0CustomElementLifecycleCallbacks::created(Element* element) {
// FIXME: callbacks while paused should be queued up for execution to
// continue then be delivered in order rather than delivered immediately.
// Bug 329665 tracks similar behavior for other synchronous events.
- if (!getExecutionContext() ||
- getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!getExecutionContext())
return;
+ // TODO(dcheng): Shouldn't this be redundant with getExecutionContext()?
if (!m_scriptState->contextIsValid())
return;
@@ -202,8 +202,7 @@ void V8V0CustomElementLifecycleCallbacks::attributeChanged(
// FIXME: callbacks while paused should be queued up for execution to
// continue then be delivered in order rather than delivered immediately.
// Bug 329665 tracks similar behavior for other synchronous events.
- if (!getExecutionContext() ||
- getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!getExecutionContext())
return;
if (!m_scriptState->contextIsValid())
@@ -238,8 +237,7 @@ void V8V0CustomElementLifecycleCallbacks::call(
// FIXME: callbacks while paused should be queued up for execution to
// continue then be delivered in order rather than delivered immediately.
// Bug 329665 tracks similar behavior for other synchronous events.
- if (!getExecutionContext() ||
- getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!getExecutionContext())
return;
if (!m_scriptState->contextIsValid())

Powered by Google App Engine
This is Rietveld 408576698