Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index 87d93525711c43f86222e5707988b4ec1ec0a64f..60f84a38d4a99c533e03f12864544db8eb91be3e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -184,7 +184,7 @@ class MajorGCWrapperVisitor : public v8::PersistentHandleVisitor {
// TODO(haraken): Implement correct lifetime using traceWrapper.
ExecutionContext* context =
toExecutionContext(wrapper->CreationContext());
- if (context && !context->activeDOMObjectsAreStopped()) {
+ if (context) {
m_isolate->SetObjectGroupId(*value, liveRootId());
++m_domObjectsWithPendingActivity;
}
@@ -516,8 +516,7 @@ class PendingActivityVisitor : public v8::PersistentHandleVisitor {
// See the comment in MajorGCWrapperVisitor::VisitPersistentHandle.
ExecutionContext* context =
toExecutionContext(wrapper->CreationContext());
- if (context == m_executionContext && context &&
- !context->activeDOMObjectsAreStopped())
+ if (context == m_executionContext && context)
m_pendingActivityFound = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698