components/sync/engine/cycle/sync_cycle_snapshot.cc - Issue 2433563002: [Sync] Reimplement proto value conversions on top of field visitors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine/cycle/sync_cycle_snapshot.cc

Issue 2433563002: [Sync] Reimplement proto value conversions on top of field visitors. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine/cycle/sync_cycle_snapshot.cc

diff --git a/components/sync/engine/cycle/sync_cycle_snapshot.cc b/components/sync/engine/cycle/sync_cycle_snapshot.cc

index 27cffce49b4e985e3e4ddc70c3c62806028cf07e..765e120e2f07227da2625bfb3e77b1bb6de527f5 100644

--- a/components/sync/engine/cycle/sync_cycle_snapshot.cc

+++ b/components/sync/engine/cycle/sync_cycle_snapshot.cc

@@ -82,8 +82,7 @@ std::unique_ptr<base::DictionaryValue> SyncCycleSnapshot::ToValue() const {

value->SetInteger("numHierarchyConflicts", num_hierarchy_conflicts_);

value->SetInteger("numServerConflicts", num_server_conflicts_);

value->SetInteger("numEntries", num_entries_);

- value->SetString("legacySource",

- GetUpdatesSourceString(legacy_updates_source_));

+ value->SetString("legacySource", ProtoEnumToString(legacy_updates_source_));

value->SetBoolean("notificationsEnabled", notifications_enabled_);

std::unique_ptr<base::DictionaryValue> counter_entries(