components/sync/driver/about_sync_util.cc - Issue 2433563002: [Sync] Reimplement proto value conversions on top of field visitors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/about_sync_util.cc

Issue 2433563002: [Sync] Reimplement proto value conversions on top of field visitors. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/about_sync_util.cc

diff --git a/components/sync/driver/about_sync_util.cc b/components/sync/driver/about_sync_util.cc

index 1cb71adb3e9bb3ac41726b8efeb651e623803558..ab8082c2b384863543e841596a46b9ea427e177d 100644

--- a/components/sync/driver/about_sync_util.cc

+++ b/components/sync/driver/about_sync_util.cc

@@ -424,7 +424,7 @@ std::unique_ptr<base::DictionaryValue> ConstructAboutInformation(

if (snapshot.legacy_updates_source() !=

sync_pb::GetUpdatesCallerInfo::UNKNOWN) {

session_source.SetValue(

- GetUpdatesSourceString(snapshot.legacy_updates_source()));

+ ProtoEnumToString(snapshot.legacy_updates_source()));

}

get_key_result.SetValue(GetSyncerErrorString(

snapshot.model_neutral_state().last_get_key_result));