Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1721)

Unified Diff: webrtc/modules/desktop_capture/desktop_capturer.h

Issue 2433503002: Remove DesktopRegion parameter from DesktopCapturer::Capture (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/desktop_capturer.h
diff --git a/webrtc/modules/desktop_capture/desktop_capturer.h b/webrtc/modules/desktop_capture/desktop_capturer.h
index 0c7b68e85d8ec9fd0502c9bb469c9efaf6095575..812e0928bfc929c83c90eec03ae6be61632c0297 100644
--- a/webrtc/modules/desktop_capture/desktop_capturer.h
+++ b/webrtc/modules/desktop_capture/desktop_capturer.h
@@ -66,12 +66,12 @@ class DesktopCapturer {
virtual void SetSharedMemoryFactory(
std::unique_ptr<SharedMemoryFactory> shared_memory_factory) {}
- // This is a legacy interface, consumers should call CaptureFrame() function.
- virtual void Capture(const DesktopRegion& region) { CaptureFrame(); }
-
// Captures next frame, and involve callback provided by Start() function.
// Pending capture requests are canceled when DesktopCapturer is deleted.
- virtual void CaptureFrame() { Capture(DesktopRegion()); }
+ virtual void Capture() { CaptureFrame(); }
Sergey Ulanov 2016/10/18 23:37:10 I think CaptureFrame() is a better name than Captu
Hzj_jie 2016/10/19 00:49:17 No opinion, yes, I can remove old Capture() functi
+
+ // This is a legacy interface, consumers should call Capture() function.
+ virtual void CaptureFrame() { Capture(); }
// Sets the window to be excluded from the captured image in the future
// Capture calls. Used to exclude the screenshare notification window for

Powered by Google App Engine
This is Rietveld 408576698