webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc - Issue 2433503002: Remove DesktopRegion parameter from DesktopCapturer::Capture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc

Issue 2433503002: Remove DesktopRegion parameter from DesktopCapturer::Capture (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc ('k') | webrtc/modules/desktop_capture/desktop_capturer.h » ('j') | webrtc/modules/desktop_capture/desktop_capturer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc

diff --git a/webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc b/webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc

index 77471b8efece40405addc71ccfb1389ea6b8e294..d952285306936c72c919b71e7dffed268c2430b5 100644

--- a/webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc

+++ b/webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc

@@ -77,7 +77,7 @@ class FakeScreenCapturer : public DesktopCapturer {

void Start(Callback* callback) override { callback_ = callback; }

- void CaptureFrame() override {

+ void Capture() override {

callback_->OnCaptureResult(

next_frame_ ? Result::SUCCESS : Result::ERROR_TEMPORARY,

std::move(next_frame_));

@@ -193,7 +193,7 @@ TEST_F(DesktopAndCursorComposerTest, Error) {

fake_cursor_->SetState(MouseCursorMonitor::INSIDE, DesktopVector());

fake_screen_->SetNextFrame(nullptr);

- blender_.CaptureFrame();

+ blender_.Capture();

EXPECT_FALSE(frame_);

}

@@ -237,7 +237,7 @@ TEST_F(DesktopAndCursorComposerTest, Blend) {

SharedDesktopFrame::Wrap(CreateTestFrame()));

fake_screen_->SetNextFrame(frame->Share());

- blender_.CaptureFrame();

+ blender_.Capture();

VerifyFrame(*frame_, state, pos);