Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2433453002: Change variations service URL on the Java side. (Closed)

Created:
4 years, 2 months ago by Alexei Svitkine (slow)
Modified:
4 years, 2 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change variations service URL on the Java side. This codepath is taken during first run seed fetching. In https://codereview.chromium.org/2223263002, I changed the URL of the regular seed fetch for Android, but forgot to also change this one. BUG=635680 Committed: https://crrev.com/04519a516180a807b2afde7c51156951753fceff Cr-Commit-Position: refs/heads/master@{#426059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedService.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-18 19:12:25 UTC) #2
rkaplow
lgtm
4 years, 2 months ago (2016-10-18 20:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433453002/1
4 years, 2 months ago (2016-10-18 20:31:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 21:39:11 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:03:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04519a516180a807b2afde7c51156951753fceff
Cr-Commit-Position: refs/heads/master@{#426059}

Powered by Google App Engine
This is Rietveld 408576698