Change variations service domain for Android Chrome.

Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

Note: Should not be submitted until we verify that the new
URL is working.

BUG=635680
Committed: https://crrev.com/1078363787edb725a21dd94993a1b8fdacd346cb
Cr-Commit-Position: refs/heads/master@{#415750}

[Alexei Svitkine (slow), 2016-08-08 21:42:54]

Description was changed from

==========
Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

BUG=635680
==========

to

==========
Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

Note: Should not be submitted until we verify that the new
URL is working.

BUG=635680
==========

[Alexei Svitkine (slow), 2016-08-08 21:43:02]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Alexei Svitkine (slow), 2016-08-08 21:43:23]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 21:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:27:24]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-08-08 22:30:09]

https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
File components/variations/variations_request_scheduler.cc (right):

https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
components/variations/variations_request_scheduler.cc:50:
variations::GetVariationParamValue("VariationsServiceControl",
this typo exists in client side logic as well. Did we want to just deprecate
this setting?

[Alexei Svitkine (slow), 2016-08-08 22:33:38]

https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
File components/variations/variations_request_scheduler.cc (right):

https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
components/variations/variations_request_scheduler.cc:50:
variations::GetVariationParamValue("VariationsServiceControl",
On 2016/08/08 22:30:09, rkaplow wrote:
> this typo exists in client side logic as well. Did we want to just deprecate
> this setting?

So we still want to keep this param, as the plan to launch the URL in another
country calls for starting with a different fetch period, which we can control
through this param.

Did you mean we have the typo somewhere or what do you mean for "client side
logic" - unless you're just talking about this code?

[rkaplow, 2016-08-08 22:36:15]

On 2016/08/08 22:33:38, Alexei Svitkine (very slow) wrote:
>
https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
> File components/variations/variations_request_scheduler.cc (right):
> 
>
https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
> components/variations/variations_request_scheduler.cc:50:
> variations::GetVariationParamValue("VariationsServiceControl",
> On 2016/08/08 22:30:09, rkaplow wrote:
> > this typo exists in client side logic as well. Did we want to just deprecate
> > this setting?
> 
> So we still want to keep this param, as the plan to launch the URL in another
> country calls for starting with a different fetch period, which we can control
> through this param.
> 
> Did you mean we have the typo somewhere or what do you mean for "client side
> logic" - unless you're just talking about this code?

Erp, I meant the server side logic. The study itself is called that.

[Alexei Svitkine (slow), 2016-08-08 22:40:34]

Ah right. We don't care about those old configs anymore - as what they have
there (30m) is the client default.

I do plan to use the new non-typo'd name to do the country specific param
change in the future.

On Mon, Aug 8, 2016 at 3:36 PM, <rkaplow@chromium.org> wrote:

> On 2016/08/08 22:33:38, Alexei Svitkine (very slow) wrote:
> >
> https://codereview.chromium.org/2223263002/diff/1/components/variations/
> variations_request_scheduler.cc
> > File components/variations/variations_request_scheduler.cc (right):
> >
> >
> https://codereview.chromium.org/2223263002/diff/1/components/variations/
> variations_request_scheduler.cc#newcode50
> > components/variations/variations_request_scheduler.cc:50:
> > variations::GetVariationParamValue("VariationsServiceControl",
> > On 2016/08/08 22:30:09, rkaplow wrote:
> > > this typo exists in client side logic as well. Did we want to just
> deprecate
> > > this setting?
> >
> > So we still want to keep this param, as the plan to launch the URL in
> another
> > country calls for starting with a different fetch period, which we can
> control
> > through this param.
> >
> > Did you mean we have the typo somewhere or what do you mean for "client
> side
> > logic" - unless you're just talking about this code?
>
> Erp, I meant the server side logic. The study itself is called that.
>
> https://codereview.chromium.org/2223263002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rkaplow, 2016-08-08 22:45:48]

lgtm

server change lg

https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
File components/variations/variations_request_scheduler.cc (right):

https://codereview.chromium.org/2223263002/diff/1/components/variations/varia...
components/variations/variations_request_scheduler.cc:50:
variations::GetVariationParamValue("VariationsServiceControl",
On 2016/08/08 22:33:38, Alexei Svitkine (very slow) wrote:
> On 2016/08/08 22:30:09, rkaplow wrote:
> > this typo exists in client side logic as well. Did we want to just deprecate
> > this setting?
> 
> So we still want to keep this param, as the plan to launch the URL in another
> country calls for starting with a different fetch period, which we can control
> through this param.
> 
> Did you mean we have the typo somewhere or what do you mean for "client side
> logic" - unless you're just talking about this code?

Ok, wasn't sure what would happen - I guess it just is empty string so wouldn't
get parsed to a number. Just double checking

[Alexei Svitkine (slow), 2016-08-08 22:52:36]

Thanks, will wait to submit until I get confirmed that the new URL is
working.

On Mon, Aug 8, 2016 at 3:45 PM, <rkaplow@chromium.org> wrote:

> lgtm
>
> server change lg
>
>
> https://codereview.chromium.org/2223263002/diff/1/components/variations/
> variations_request_scheduler.cc
> File components/variations/variations_request_scheduler.cc (right):
>
> https://codereview.chromium.org/2223263002/diff/1/components/variations/
> variations_request_scheduler.cc#newcode50
> components/variations/variations_request_scheduler.cc:50:
> variations::GetVariationParamValue("VariationsServiceControl",
> On 2016/08/08 22:33:38, Alexei Svitkine (very slow) wrote:
> > On 2016/08/08 22:30:09, rkaplow wrote:
> > > this typo exists in client side logic as well. Did we want to just
> deprecate
> > > this setting?
> >
> > So we still want to keep this param, as the plan to launch the URL in
> another
> > country calls for starting with a different fetch period, which we can
> control
> > through this param.
> >
> > Did you mean we have the typo somewhere or what do you mean for
> "client side
> > logic" - unless you're just talking about this code?
>
> Ok, wasn't sure what would happen - I guess it just is empty string so
> wouldn't get parsed to a number. Just double checking
>
> https://codereview.chromium.org/2223263002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2016-08-31 18:56:52]

Verified that the new URL is working. Will rebase and commit.

[Alexei Svitkine (slow), 2016-08-31 19:04:58]

Rebased. cq-ing.

[Alexei Svitkine (slow), 2016-08-31 19:05:02]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-08-31 19:05:02]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2223263002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-31 19:05:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 20:59:30]

Description was changed from

==========
Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

Note: Should not be submitted until we verify that the new
URL is working.

BUG=635680
==========

to

==========
Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

Note: Should not be submitted until we verify that the new
URL is working.

BUG=635680
==========

[commit-bot: I haz the power, 2016-08-31 20:59:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 21:04:36]

Description was changed from

==========
Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

Note: Should not be submitted until we verify that the new
URL is working.

BUG=635680
==========

to

==========
Change variations service domain for Android Chrome.

The new domain is clientservices.googleapis.com.

Also, removes testing config for VarationsServiceControl
30m interval trial, since that's the client default.
Updates the parameter code for the fetch interval to fix
the typo in the trial name.

Note: Should not be submitted until we verify that the new
URL is working.

BUG=635680

Committed: https://crrev.com/1078363787edb725a21dd94993a1b8fdacd346cb
Cr-Commit-Position: refs/heads/master@{#415750}
==========

[commit-bot: I haz the power, 2016-08-31 21:04:37]

Patchset 2 (id:??) landed as
https://crrev.com/1078363787edb725a21dd94993a1b8fdacd346cb
Cr-Commit-Position: refs/heads/master@{#415750}