Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 243333003: Add back three deprecated DOM APIs removed from Chrome 34 (Closed)

Created:
6 years, 8 months ago by eseidel
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, ojan, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive, dominicc (has gone to gerrit), abarth-chromium, esprehn
Visibility:
Public.

Description

Add back three deprecated DOM APIs removed from Chrome 34 I added back the APIs and marked them as deprecated. I carefully checked to make sure they're using the same UseCounter ids as they were before. I did not add back the removed tests as it did not seem worth the hassle of dealing with the conflicts and rebaselines necessary due to the new deprecation messages. These API removes are believed to have broken an unknown number of Chrome users in enterprise environments. Users in these settings are likely biased away from having "anonymous chrome usage data" reporting enabled meaning that their usage may not be reflected in the data displayed at chromestatus.com. All we have currently is anecdotal data such as comments on mailing lists or in bugs reporting "100s of customers" from SAP as affected (crbug.com/364028). These APIs were removed from Blink as "low hanging fruit". Each of these sees fewer than 1 view of every 1 million anonymously reported chrome views (well below our historical removal thresholds) and removing them is a step towards the larger removal of Attr nodes from the DOM (as has been proposed for the DOM 4 specification). However the reward for the 99.99% of users who do not use these features is quite small. The risk to this unknown number of Blink "enterprise" users is likely too large to be worth the small code complexity reward at this time. Adding these back for now, with deprecation messages. We'll likely remove these again from Blink in the future as usage of these features continues to decline and hopefully our measurement of enterprise usage improves. BUG=341830, 341296, 353104, 364028 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171971

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make urls clickable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M LayoutTests/dom/xhtml/level3/core/documentadoptnode01-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode02-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode03-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode04-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode05-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode21-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
6 years, 8 months ago (2014-04-18 19:17:18 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/243333003/diff/1/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/243333003/diff/1/Source/core/frame/UseCounter.cpp#newcode714 Source/core/frame/UseCounter.cpp:714: return "'Document.createAttributeNS' is deprecated and has been removed ...
6 years, 8 months ago (2014-04-18 19:19:56 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-18 19:26:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/243333003/20001
6 years, 8 months ago (2014-04-18 19:26:24 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 20:34:27 UTC) #5
Message was sent while issue was closed.
Change committed as 171971

Powered by Google App Engine
This is Rietveld 408576698