Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp

Issue 2433273003: service worker: Plumb NavigationPreloadManager.enable/disable to browser-side (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
index 1b03b42962dbc9bca354814e44a792a3bf420769..9e89e742e841bfd088d59555146a89e1be49197b 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
@@ -4,25 +4,19 @@
#include "modules/serviceworkers/NavigationPreloadManager.h"
+#include "core/dom/DOMException.h"
#include "modules/serviceworkers/NavigationPreloadCallbacks.h"
+#include "modules/serviceworkers/ServiceWorkerContainerClient.h"
#include "modules/serviceworkers/ServiceWorkerRegistration.h"
namespace blink {
ScriptPromise NavigationPreloadManager::enable(ScriptState* scriptState) {
- ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
- ScriptPromise promise = resolver->promise();
- m_registration->webRegistration()->enableNavigationPreload(
- new EnableNavigationPreloadCallbacks(resolver));
- return promise;
+ return setEnabled(true, scriptState);
}
ScriptPromise NavigationPreloadManager::disable(ScriptState* scriptState) {
- ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
- ScriptPromise promise = resolver->promise();
- m_registration->webRegistration()->disableNavigationPreload(
- new DisableNavigationPreloadCallbacks(resolver));
- return promise;
+ return setEnabled(false, scriptState);
}
ScriptPromise NavigationPreloadManager::setHeaderValue(ScriptState*,
@@ -40,6 +34,22 @@ NavigationPreloadManager::NavigationPreloadManager(
ServiceWorkerRegistration* registration)
: m_registration(registration) {}
+ScriptPromise NavigationPreloadManager::setEnabled(bool enable,
+ ScriptState* scriptState) {
+ ServiceWorkerContainerClient* client =
+ ServiceWorkerContainerClient::from(m_registration->getExecutionContext());
+ if (!client || !client->provider()) {
+ return ScriptPromise::rejectWithDOMException(
+ scriptState, DOMException::create(InvalidStateError, "No provider."));
+ }
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromise promise = resolver->promise();
+ m_registration->webRegistration()->enableNavigationPreload(
+ enable, client->provider(),
+ wrapUnique(new EnableNavigationPreloadCallbacks(resolver)));
+ return promise;
+}
+
DEFINE_TRACE(NavigationPreloadManager) {
visitor->trace(m_registration);
}

Powered by Google App Engine
This is Rietveld 408576698