third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h - Issue 2433273003: service worker: Plumb NavigationPreloadManager.enable/disable to browser-side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 2433273003: service worker: Plumb NavigationPreloadManager.enable/disable to browser-side (Closed)

Patch Set: comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

index c7a393d75567734d53cdfbaa7c1dde2c69a3ff76..fe5ba1b332179e13ce47b84d58dfcf2780685a04 100644

--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

@@ -28,8 +28,6 @@ class WebServiceWorkerRegistration {

WebCallbacks<bool, const WebServiceWorkerError&>;

using WebEnableNavigationPreloadCallbacks =

WebCallbacks<void, const WebServiceWorkerError&>;

- using WebDisableNavigationPreloadCallbacks =

- WebCallbacks<void, const WebServiceWorkerError&>;

// The handle interface that retains a reference to the implementation of

// WebServiceWorkerRegistration in the embedder and is owned by

@@ -51,8 +49,10 @@ class WebServiceWorkerRegistration {

virtual void unregister(WebServiceWorkerProvider*,

WebServiceWorkerUnregistrationCallbacks*) {}

- virtual void enableNavigationPreload(WebEnableNavigationPreloadCallbacks*) {}

- virtual void disableNavigationPreload(WebEnableNavigationPreloadCallbacks*) {}

+ virtual void enableNavigationPreload(

+ bool enable,

+ WebServiceWorkerProvider*,

+ std::unique_ptr<WebEnableNavigationPreloadCallbacks>) {}

};

} // namespace blink