Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Unified Diff: xfa/fwl/lightwidget/cfwl_checkbox.cpp

Issue 2433133002: Remove IFWL_*::Create methods, use new (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/lightwidget/cfwl_checkbox.cpp
diff --git a/xfa/fwl/lightwidget/cfwl_checkbox.cpp b/xfa/fwl/lightwidget/cfwl_checkbox.cpp
index d14ed51b3ba2d177d36483fc1a1ac760aa987d16..a9bba805f1c8a20c9cbf38c52704b7a94aca4389 100644
--- a/xfa/fwl/lightwidget/cfwl_checkbox.cpp
+++ b/xfa/fwl/lightwidget/cfwl_checkbox.cpp
@@ -8,6 +8,7 @@
#include <memory>
+#include "third_party/base/ptr_util.h"
#include "xfa/fwl/core/fwl_error.h"
IFWL_CheckBox* CFWL_CheckBox::GetWidget() {
@@ -24,8 +25,8 @@ FWL_Error CFWL_CheckBox::Initialize(const CFWL_WidgetProperties* pProperties) {
if (pProperties) {
*m_pProperties = *pProperties;
}
- std::unique_ptr<IFWL_CheckBox> pCheckBox(IFWL_CheckBox::Create(
- m_pProperties->MakeWidgetImpProperties(&m_checkboxData), nullptr));
+ std::unique_ptr<IFWL_CheckBox> pCheckBox = pdfium::MakeUnique<IFWL_CheckBox>(
+ m_pProperties->MakeWidgetImpProperties(&m_checkboxData));
Wei Li 2016/10/19 17:13:07 Ditto for others
dsinclair 2016/10/19 17:21:28 Done.
FWL_Error ret = pCheckBox->Initialize();
if (ret != FWL_Error::Succeeded) {
return ret;

Powered by Google App Engine
This is Rietveld 408576698