Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: xfa/fwl/lightwidget/cfwl_checkbox.cpp

Issue 2433133002: Remove IFWL_*::Create methods, use new (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/lightwidget/cfwl_checkbox.h" 7 #include "xfa/fwl/lightwidget/cfwl_checkbox.h"
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "third_party/base/ptr_util.h"
11 #include "xfa/fwl/core/fwl_error.h" 12 #include "xfa/fwl/core/fwl_error.h"
12 13
13 IFWL_CheckBox* CFWL_CheckBox::GetWidget() { 14 IFWL_CheckBox* CFWL_CheckBox::GetWidget() {
14 return static_cast<IFWL_CheckBox*>(m_pIface.get()); 15 return static_cast<IFWL_CheckBox*>(m_pIface.get());
15 } 16 }
16 17
17 const IFWL_CheckBox* CFWL_CheckBox::GetWidget() const { 18 const IFWL_CheckBox* CFWL_CheckBox::GetWidget() const {
18 return static_cast<IFWL_CheckBox*>(m_pIface.get()); 19 return static_cast<IFWL_CheckBox*>(m_pIface.get());
19 } 20 }
20 21
21 FWL_Error CFWL_CheckBox::Initialize(const CFWL_WidgetProperties* pProperties) { 22 FWL_Error CFWL_CheckBox::Initialize(const CFWL_WidgetProperties* pProperties) {
22 if (m_pIface) 23 if (m_pIface)
23 return FWL_Error::Indefinite; 24 return FWL_Error::Indefinite;
24 if (pProperties) { 25 if (pProperties) {
25 *m_pProperties = *pProperties; 26 *m_pProperties = *pProperties;
26 } 27 }
27 std::unique_ptr<IFWL_CheckBox> pCheckBox(IFWL_CheckBox::Create( 28 std::unique_ptr<IFWL_CheckBox> pCheckBox = pdfium::MakeUnique<IFWL_CheckBox>(
28 m_pProperties->MakeWidgetImpProperties(&m_checkboxData), nullptr)); 29 m_pProperties->MakeWidgetImpProperties(&m_checkboxData));
Wei Li 2016/10/19 17:13:07 Ditto for others
dsinclair 2016/10/19 17:21:28 Done.
29 FWL_Error ret = pCheckBox->Initialize(); 30 FWL_Error ret = pCheckBox->Initialize();
30 if (ret != FWL_Error::Succeeded) { 31 if (ret != FWL_Error::Succeeded) {
31 return ret; 32 return ret;
32 } 33 }
33 m_pIface = std::move(pCheckBox); 34 m_pIface = std::move(pCheckBox);
34 CFWL_Widget::Initialize(); 35 CFWL_Widget::Initialize();
35 return FWL_Error::Succeeded; 36 return FWL_Error::Succeeded;
36 } 37 }
37 38
38 FWL_Error CFWL_CheckBox::SetCaption(const CFX_WideStringC& wsCaption) { 39 FWL_Error CFWL_CheckBox::SetCaption(const CFX_WideStringC& wsCaption) {
(...skipping 24 matching lines...) Expand all
63 FWL_Error CFWL_CheckBox::CFWL_CheckBoxDP::GetCaption( 64 FWL_Error CFWL_CheckBox::CFWL_CheckBoxDP::GetCaption(
64 IFWL_Widget* pWidget, 65 IFWL_Widget* pWidget,
65 CFX_WideString& wsCaption) { 66 CFX_WideString& wsCaption) {
66 wsCaption = m_wsCaption; 67 wsCaption = m_wsCaption;
67 return FWL_Error::Succeeded; 68 return FWL_Error::Succeeded;
68 } 69 }
69 70
70 FX_FLOAT CFWL_CheckBox::CFWL_CheckBoxDP::GetBoxSize(IFWL_Widget* pWidget) { 71 FX_FLOAT CFWL_CheckBox::CFWL_CheckBoxDP::GetBoxSize(IFWL_Widget* pWidget) {
71 return m_fBoxHeight; 72 return m_fBoxHeight;
72 } 73 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698