Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

Issue 2432543002: Refactoring WorkletThreadBackingHolder with template pattern (Closed)
Patch Set: Fixing typos Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
diff --git a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h b/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
index b976d6d0cd8e24977bb7fb450f64a3ea5b11163e..52ed15cba20f1f22b60e1ddd8abea2b42a0c98f3 100644
--- a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
+++ b/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
@@ -21,20 +21,20 @@ class MODULES_EXPORT AbstractAnimationWorkletThread : public WorkerThread {
~AbstractAnimationWorkletThread() override;
WorkerBackingThread& workerBackingThread() override;
- void clearWorkerBackingThread() override {
- // Do nothing.
- // The backing thread is cleared by clearSharedBackingThread().
- }
+
+ // The backing thread is cleared by clearSharedBackingThread().
+ void clearWorkerBackingThread() override {}
bool shouldAttachThreadDebugger() const override { return false; }
+ // This may block the main thread.
static void collectAllGarbage();
static void ensureSharedBackingThread();
- static void createSharedBackingThreadForTest();
-
static void clearSharedBackingThread();
+ static void createSharedBackingThreadForTest();
+
protected:
AbstractAnimationWorkletThread(PassRefPtr<WorkerLoaderProxy>,
WorkerReportingProxy&);

Powered by Google App Engine
This is Rietveld 408576698