Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2432453002: Fixing bad cleanup of multi part flag #endifs. (Closed)

Created:
4 years, 2 months ago by skym
Modified:
4 years, 2 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing bad cleanup of multi part flag #endifs. BUG= Committed: https://crrev.com/7248671d1809b1ba654f478490ced3e9cfa52945 Cr-Commit-Position: refs/heads/master@{#426036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M chrome/browser/about_flags.cc View 15 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
skym
PTAL. I messed up multi part #endifs in my previous CL https://codereview.chromium.org/2369673002 and this is ...
4 years, 2 months ago (2016-10-18 15:00:43 UTC) #4
rkaplow
lgtm ah, sorry i missed
4 years, 2 months ago (2016-10-18 20:22:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432453002/1
4 years, 2 months ago (2016-10-18 20:33:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 20:38:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:02:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7248671d1809b1ba654f478490ced3e9cfa52945
Cr-Commit-Position: refs/heads/master@{#426036}

Powered by Google App Engine
This is Rietveld 408576698