|
|
Chromium Code Reviews
DescriptionClean up about_flags.cc.
BUG=
Committed: https://crrev.com/d6d2c8d33d7dfbcb927950a6f5b65c2e0d6520db
Cr-Commit-Position: refs/heads/master@{#421014}
Patch Set 1 #Patch Set 2 : Removing defined() wrapping on closing comments. #Patch Set 3 : Rebase #Patch Set 4 : Rebase again. #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by skym@chromium.org to run a CQ dry run
Description was changed from ========== Clean up about_flags.cc. BUG= ========== to ========== Clean up about_flags.cc. BUG= ==========
skym@chromium.org changed reviewers: + rkaplow@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
The CQ bit was checked by skym@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2369673002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by skym@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2369673002/#ps60001 (title: "Rebase again.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Clean up about_flags.cc. BUG= ========== to ========== Clean up about_flags.cc. BUG= ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Clean up about_flags.cc. BUG= ========== to ========== Clean up about_flags.cc. BUG= Committed: https://crrev.com/d6d2c8d33d7dfbcb927950a6f5b65c2e0d6520db Cr-Commit-Position: refs/heads/master@{#421014} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d6d2c8d33d7dfbcb927950a6f5b65c2e0d6520db Cr-Commit-Position: refs/heads/master@{#421014} |
