Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2369673002: Clean up about_flags.cc. (Closed)

Created:
4 years, 3 months ago by skym
Modified:
4 years, 2 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up about_flags.cc. BUG= Committed: https://crrev.com/d6d2c8d33d7dfbcb927950a6f5b65c2e0d6520db Cr-Commit-Position: refs/heads/master@{#421014}

Patch Set 1 #

Patch Set 2 : Removing defined() wrapping on closing comments. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -116 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 76 chunks +111 lines, -116 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
skym
PTAL
4 years, 3 months ago (2016-09-24 00:04:29 UTC) #4
rkaplow
lgtm
4 years, 2 months ago (2016-09-26 14:52:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369673002/40001
4 years, 2 months ago (2016-09-26 20:25:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/75260) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-26 20:28:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369673002/60001
4 years, 2 months ago (2016-09-26 20:36:49 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-26 22:06:41 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 22:08:57 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d6d2c8d33d7dfbcb927950a6f5b65c2e0d6520db
Cr-Commit-Position: refs/heads/master@{#421014}

Powered by Google App Engine
This is Rietveld 408576698