Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 243243003: anticipate more optimizations by renaming some files and methods (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
f(malita), mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

anticipate more optimizations by renaming some files and methods also, call the new SkRecordOptimize in bench_playback BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -71 lines) Patch
M gyp/record.gyp View 1 chunk +1 line, -1 line 0 comments Download
D src/record/SkRecordCulling.h View 1 chunk +0 lines, -16 lines 0 comments Download
D src/record/SkRecordCulling.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
A + src/record/SkRecordOpts.h View 1 chunk +8 lines, -4 lines 0 comments Download
A + src/record/SkRecordOpts.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/record/SkRecording.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordCullingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/bench_playback.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 8 months ago (2014-04-18 16:10:19 UTC) #1
mtklein
Same deal. Landing this refactoring to cut out noise from a more interesting dependent CL.
6 years, 8 months ago (2014-04-21 14:42:42 UTC) #2
mtklein
lgtm
6 years, 8 months ago (2014-04-21 14:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/243243003/1
6 years, 8 months ago (2014-04-21 14:42:54 UTC) #4
f(malita)
Belated lgtm.
6 years, 8 months ago (2014-04-21 14:46:02 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 15:03:47 UTC) #6
Message was sent while issue was closed.
Change committed as 14277

Powered by Google App Engine
This is Rietveld 408576698