Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: appengine/findit/util_scripts/crash_queries/crash_iterator.py

Issue 2432203003: [Predator] Run predator. (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/util_scripts/crash_queries/crash_iterator.py
diff --git a/appengine/findit/util_scripts/crash_queries/crash_iterator.py b/appengine/findit/util_scripts/crash_queries/crash_iterator.py
index 930b6a5e3e2345de698c4399ec6eb97537fe0433..3a02e9a610a80dbda5f5d71b6a97e48b5d0dde4c 100644
--- a/appengine/findit/util_scripts/crash_queries/crash_iterator.py
+++ b/appengine/findit/util_scripts/crash_queries/crash_iterator.py
@@ -10,15 +10,11 @@ from crash.type_enums import CrashClient
import iterator
from model.crash.cracas_crash_analysis import CracasCrashAnalysis
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
-import remote_api
_DEFAULT_BATCH_SIZE = 1000
_TODAY = date.today().strftime('%Y-%m-%d')
_A_YEAR_AGO = (date.today() - timedelta(days=365)).strftime('%Y-%m-%d')
-COMMON_CRASH_FIELDS = ['crashed_version', 'stack_trace', 'signature',
- 'platform', 'client_id', 'customized_data']
-
# TODO(katesonia): Switch to use fuction of objects encapsulating CrashClients,
# after the refactoring is done.
@@ -80,13 +76,11 @@ def IterateCrashes(client_id,
An example is available in crash_printer/print_crash.py.
"""
- if fields is None:
- fields = COMMON_CRASH_FIELDS
-
if property_values is None:
property_values = {}
query = GetQueryForClient(client_id, property_values, start_date, end_date)
- for crash in iterator.Iterate(query, fields, app_id, batch_size=batch_size,
+ for crash in iterator.Iterate(query, app_id, fields=fields,
+ batch_size=batch_size,
batch_run=batch_run):
yield crash

Powered by Google App Engine
This is Rietveld 408576698