Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2113)

Unified Diff: appengine/findit/handlers/crash/test/crash_handler_test.py

Issue 2432203003: [Predator] Run predator. (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/crash/test/crash_handler_test.py
diff --git a/appengine/findit/handlers/crash/test/crash_handler_test.py b/appengine/findit/handlers/crash/test/crash_handler_test.py
index 5728514e3979d2439de9a60698f276bf883ef372..ee59333fb658abea16c575bd5872d540037d0ff1 100644
--- a/appengine/findit/handlers/crash/test/crash_handler_test.py
+++ b/appengine/findit/handlers/crash/test/crash_handler_test.py
@@ -92,7 +92,7 @@ class CrashHandlerTest(CrashTestCase):
return False
self.mock(crash_pipeline, 'FinditForClientID',
- lambda _client_id: _MockFindit())
+ lambda _client_id, repository: _MockFindit())
self.assertFalse(crash_handler.ScheduleNewAnalysis(original_crash_data))
def testScheduleNewAnalysisSkipsUnsupportedChannel(self):
@@ -245,11 +245,6 @@ class CrashHandlerTest(CrashTestCase):
client_id = CrashClient.FRACAS,
version = '50.2500.0.1',
stack_trace = 'frame1\nframe2\nframe3')
- # A fake repository, needed by the Findit constructor. We should never
- # go over the wire (e.g., in the call to ScheduleNewAnalysis below),
- # and this helps ensure that.
- self.mock(gitiles_repository, 'GitilesRepository',
- lambda *_args, **_kwargs: None)
self.assertTrue(crash_handler.ScheduleNewAnalysis(crash_data))
# The catch/re-raise is to clean up the callstack that's reported
« no previous file with comments | « appengine/findit/handlers/crash/crash_handler.py ('k') | appengine/findit/util_scripts/crash_queries/crash_iterator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698