third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode() (Closed)

Patch Set: 2016-10-20T13:46:03 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 89143181b1ed0c4af14094a4371065d10cb4b3f3..e2141461cfec85ff973897674e6afc3caae0ea83 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -233,7 +233,8 @@ ReplacementFragment::ReplacementFragment(Document* document,

}

const EphemeralRange range =

- VisibleSelection::selectionFromContentsOfNode(holder)

+ createVisibleSelection(

+ SelectionInDOMTree::Builder().selectAllChildren(*holder).build())

.toNormalizedEphemeralRange();

String text = plainText(range, static_cast<TextIteratorBehavior>(

TextIteratorEmitsOriginalText |