Get rid of VisibleSelection::selectionFromContentsOfNode()

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index fb3069fe61f76e94f0d4211defb816f5f0074449..4d95a27fcc150680fec885f0e6444a1613c44039 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -207,19 +207,6 @@ operator=(const VisibleSelectionTemplate<Strategy>& other) {
 }
 
 template <typename Strategy>
-VisibleSelectionTemplate<Strategy>
-VisibleSelectionTemplate<Strategy>::selectionFromContentsOfNode(Node* node) {
-  DCHECK(node);
-  DCHECK(!Strategy::editingIgnoresContent(node));

[Xiaocheng, 2016/10/20 07:51:03]

Can we keep this DCHECK in SelectionTemplate::Builder::selectAllChildren?

[yosin_UTC9, 2016/10/20 08:35:34]

Sure but use |Node::canContainRangeEndPoint()| only since
|isEmptyNonEditableNodeInEditable(node)| requires clean layout tree due by
hasEditableStyle().

Note: WebKit's editingIgnoresContent(node) = !node.canContainRangeEndPoint()
http://trac.webkit.org/browser/trunk/Source/WebCore/editing/htmlediting.h

It seems we should make Blink use editingIgnoresContent() as of WebKit,
otherwise we should put update layout into call path of editingIgnoresContent().

-  DCHECK(!needsLayoutTreeUpdate(*node));
-
-  typename SelectionTemplate<Strategy>::Builder builder;
-  builder.collapse(PositionTemplate<Strategy>::firstPositionInNode(node))
-      .extend(PositionTemplate<Strategy>::lastPositionInNode(node));
-  return VisibleSelectionTemplate::create(builder.build());
-}
-
-template <typename Strategy>
 void VisibleSelectionTemplate<Strategy>::setBase(
     const PositionTemplate<Strategy>& position) {
   DCHECK(!needsLayoutTreeUpdate(position));