Get rid of VisibleSelection::selectionFromContentsOfNode()

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 189 matching lines @@
   m_affinity = other.m_affinity;
   m_selectionType = other.m_selectionType;
   m_baseIsFirst = other.m_baseIsFirst;
   m_isDirectional = other.m_isDirectional;
   m_granularity = other.m_granularity;
   m_hasTrailingWhitespace = other.m_hasTrailingWhitespace;
   return *this;
 }
 
 template <typename Strategy>
-VisibleSelectionTemplate<Strategy>
-VisibleSelectionTemplate<Strategy>::selectionFromContentsOfNode(Node* node) {
-  DCHECK(node);
-  DCHECK(!Strategy::editingIgnoresContent(node));

[Xiaocheng, 2016/10/20 07:51:03]

Can we keep this DCHECK in SelectionTemplate::Builder::selectAllChildren?

[yosin_UTC9, 2016/10/20 08:35:34]

Sure but use |Node::canContainRangeEndPoint()| only since
|isEmptyNonEditableNodeInEditable(node)| requires clean layout tree due by
hasEditableStyle().

Note: WebKit's editingIgnoresContent(node) = !node.canContainRangeEndPoint()
http://trac.webkit.org/browser/trunk/Source/WebCore/editing/htmlediting.h

It seems we should make Blink use editingIgnoresContent() as of WebKit,
otherwise we should put update layout into call path of editingIgnoresContent().

-  DCHECK(!needsLayoutTreeUpdate(*node));
-
-  typename SelectionTemplate<Strategy>::Builder builder;
-  builder.collapse(PositionTemplate<Strategy>::firstPositionInNode(node))
-      .extend(PositionTemplate<Strategy>::lastPositionInNode(node));
-  return VisibleSelectionTemplate::create(builder.build());
-}
-
-template <typename Strategy>
 void VisibleSelectionTemplate<Strategy>::setBase(
     const PositionTemplate<Strategy>& position) {
   DCHECK(!needsLayoutTreeUpdate(position));
   m_base = position;
   validate();
 }
 
 template <typename Strategy>
 void VisibleSelectionTemplate<Strategy>::setBase(
     const VisiblePositionTemplate<Strategy>& visiblePosition) {
@@ skipping 694 matching lines @@
 
 void showTree(const blink::VisibleSelectionInFlatTree& sel) {
   sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelectionInFlatTree* sel) {
   if (sel)
     sel->showTreeForThis();
 }
 #endif