Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode() (Closed)
Patch Set: 2016-10-20T13:46:03 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index d7849492e01e802981a1c17d844e972d10ba3aab..e14067f6ccde2ccd7e85eab640b61f99303bd30f 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -996,13 +996,7 @@ void FrameSelection::selectAll() {
return;
}
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- document().updateStyleAndLayoutIgnorePendingStylesheets();
-
- VisibleSelection newSelection(
- VisibleSelection::selectionFromContentsOfNode(root));
- setSelection(newSelection);
+ setSelection(SelectionInDOMTree::Builder().selectAllChildren(*root).build());
selectFrameElementInParentIfFullySelected();
notifyLayoutObjectOfSelectionChange(UserTriggered);
}

Powered by Google App Engine
This is Rietveld 408576698