Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2432153006: Increase timeouts of CustomTabActivityTests (Closed)

Created:
4 years, 2 months ago by kraush
Modified:
4 years, 1 month ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase timeouts of CustomTabActivityTests CustomTabActivityTests currently have timeout that will have a very high flakyness rate on some devices. This change increases them to make sure it does not flake. BUG=657527 Committed: https://crrev.com/1b65767eda1eaf76059c5eea817b53b0c9fdf332 Cr-Commit-Position: refs/heads/master@{#427787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java View 5 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kraush
Hi Yusuf, Can you take a look at this timeout increase to fix CustomTabActivityTests for ...
4 years, 2 months ago (2016-10-19 17:54:30 UTC) #2
Yusuf
lgtm
4 years, 1 month ago (2016-10-26 18:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432153006/1
4 years, 1 month ago (2016-10-26 19:15:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 21:08:37 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:12:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b65767eda1eaf76059c5eea817b53b0c9fdf332
Cr-Commit-Position: refs/heads/master@{#427787}

Powered by Google App Engine
This is Rietveld 408576698