Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java

Issue 2432153006: Increase timeouts of CustomTabActivityTests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
index fa811f3496d6358d9aaf55c33fc83d8e77437196..1e25b6d54ddecdddcb0eb553b6b363ae621d6ee7 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.customtabs;
+import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;
+
import android.app.Activity;
import android.app.Instrumentation;
import android.content.Intent;
@@ -16,6 +18,7 @@ import org.chromium.content.browser.test.util.CallbackHelper;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
+import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
/**
@@ -24,6 +27,9 @@ import java.util.concurrent.TimeoutException;
public abstract class CustomTabActivityTestBase extends
ChromeActivityTestCaseBase<CustomTabActivity> {
+ protected static final long STARTUP_TIMEOUT_MS = scaleTimeout(5) * 1000;
+ protected static final long LONG_TIMEOUT_MS = scaleTimeout(10) * 1000;
+
public CustomTabActivityTestBase() {
super(CustomTabActivity.class);
}
@@ -66,7 +72,10 @@ public abstract class CustomTabActivityTestBase extends
}
});
try {
- if (tab.isLoading()) pageLoadFinishedHelper.waitForCallback(0);
+ if (tab.isLoading()) {
+ pageLoadFinishedHelper.waitForCallback(0, 1, LONG_TIMEOUT_MS,
+ TimeUnit.MILLISECONDS);
+ }
} catch (TimeoutException e) {
fail();
}
@@ -75,7 +84,7 @@ public abstract class CustomTabActivityTestBase extends
public boolean isSatisfied() {
return DeferredStartupHandler.getInstance().isDeferredStartupCompleteForApp();
}
- }, 5000, 200);
+ }, STARTUP_TIMEOUT_MS, CriteriaHelper.DEFAULT_POLLING_INTERVAL);
assertNotNull(tab);
assertNotNull(tab.getView());
}
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698