Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1962)

Unified Diff: remoting/protocol/webrtc_frame_scheduler_unittest.cc

Issue 2431843002: Update WebrtcFrameScheduler to avoid concurrent captures. (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/webrtc_frame_scheduler_simple.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_frame_scheduler_unittest.cc
diff --git a/remoting/protocol/webrtc_frame_scheduler_unittest.cc b/remoting/protocol/webrtc_frame_scheduler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3a578e340d25b6342e34ed99ade925ef71c848ca
--- /dev/null
+++ b/remoting/protocol/webrtc_frame_scheduler_unittest.cc
@@ -0,0 +1,68 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/protocol/webrtc_frame_scheduler.h"
+
+#include "base/test/test_simple_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "remoting/protocol/webrtc_dummy_video_encoder.h"
+#include "remoting/protocol/webrtc_frame_scheduler_simple.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace remoting {
+namespace protocol {
+
+class WebrtcFrameSchedulerTest : public ::testing::Test {
+ public:
+ WebrtcFrameSchedulerTest()
+ : task_runner_(new base::TestSimpleTaskRunner()),
+ task_runner_handle_(task_runner_.get()) {
+ video_encoder_factory_.reset(new WebrtcDummyVideoEncoderFactory());
+ scheduler_.reset(new WebrtcFrameSchedulerSimple());
+ scheduler_->Start(video_encoder_factory_.get(),
+ base::Bind(&WebrtcFrameSchedulerTest::CaptureCallback,
+ base::Unretained(this)));
+ }
+ ~WebrtcFrameSchedulerTest() override {}
+
+ void CaptureCallback() { capture_callback_called_ = true; }
+
+ void VerifyCaptureCallbackCalled() {
+ EXPECT_TRUE(capture_callback_called_);
+ capture_callback_called_ = false;
+ }
+
+ protected:
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ base::ThreadTaskRunnerHandle task_runner_handle_;
+
+ std::unique_ptr<WebrtcDummyVideoEncoderFactory> video_encoder_factory_;
+ std::unique_ptr<WebrtcFrameScheduler> scheduler_;
+
+ bool capture_callback_called_ = false;
+};
+
+TEST_F(WebrtcFrameSchedulerTest, UpdateBitrateWhenPending) {
+ auto video_channel_observer =
+ video_encoder_factory_->get_video_channel_state_observer_for_tests();
+
+ video_channel_observer->OnKeyFrameRequested();
+ video_channel_observer->OnTargetBitrateChanged(100);
+
+ EXPECT_TRUE(task_runner_->HasPendingTask());
+ task_runner_->RunPendingTasks();
+
+ VerifyCaptureCallbackCalled();
+
+ video_channel_observer->OnTargetBitrateChanged(1001);
+
+ // |task_runner_| shouldn't have pending tasks as the scheduler should be
+ // waiting for the previous capture request to complete.
+ EXPECT_FALSE(task_runner_->HasPendingTask());
+}
+
+// TODO(sergeyu): Add more unittests.
+
+} // namespace protocol
+} // namespace remoting
« no previous file with comments | « remoting/protocol/webrtc_frame_scheduler_simple.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698