Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: remoting/protocol/webrtc_frame_scheduler_unittest.cc

Issue 2431843002: Update WebrtcFrameScheduler to avoid concurrent captures. (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/protocol/webrtc_frame_scheduler_simple.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "remoting/protocol/webrtc_frame_scheduler.h"
6
7 #include "base/test/test_simple_task_runner.h"
8 #include "base/threading/thread_task_runner_handle.h"
9 #include "remoting/protocol/webrtc_dummy_video_encoder.h"
10 #include "remoting/protocol/webrtc_frame_scheduler_simple.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace remoting {
14 namespace protocol {
15
16 class WebrtcFrameSchedulerTest : public ::testing::Test {
17 public:
18 WebrtcFrameSchedulerTest()
19 : task_runner_(new base::TestSimpleTaskRunner()),
20 task_runner_handle_(task_runner_.get()) {
21 video_encoder_factory_.reset(new WebrtcDummyVideoEncoderFactory());
22 scheduler_.reset(new WebrtcFrameSchedulerSimple());
23 scheduler_->Start(video_encoder_factory_.get(),
24 base::Bind(&WebrtcFrameSchedulerTest::CaptureCallback,
25 base::Unretained(this)));
26 }
27 ~WebrtcFrameSchedulerTest() override {}
28
29 void CaptureCallback() { capture_callback_called_ = true; }
30
31 void VerifyCaptureCallbackCalled() {
32 EXPECT_TRUE(capture_callback_called_);
33 capture_callback_called_ = false;
34 }
35
36 protected:
37 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
38 base::ThreadTaskRunnerHandle task_runner_handle_;
39
40 std::unique_ptr<WebrtcDummyVideoEncoderFactory> video_encoder_factory_;
41 std::unique_ptr<WebrtcFrameScheduler> scheduler_;
42
43 bool capture_callback_called_ = false;
44 };
45
46 TEST_F(WebrtcFrameSchedulerTest, UpdateBitrateWhenPending) {
47 auto video_channel_observer =
48 video_encoder_factory_->get_video_channel_state_observer_for_tests();
49
50 video_channel_observer->OnKeyFrameRequested();
51 video_channel_observer->OnTargetBitrateChanged(100);
52
53 EXPECT_TRUE(task_runner_->HasPendingTask());
54 task_runner_->RunPendingTasks();
55
56 VerifyCaptureCallbackCalled();
57
58 video_channel_observer->OnTargetBitrateChanged(1001);
59
60 // |task_runner_| shouldn't have pending tasks as the scheduler should be
61 // waiting for the previous capture request to complete.
62 EXPECT_FALSE(task_runner_->HasPendingTask());
63 }
64
65 // TODO(sergeyu): Add more unittests.
66
67 } // namespace protocol
68 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/protocol/webrtc_frame_scheduler_simple.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698